Add version check for buggy Poco libraries. #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, need to add |
Blaquewithaq
approved these changes
Jan 19, 2024
kblaschke
force-pushed
the
check-poco-version
branch
from
4ac94b5
to
83f5deb
Compare
Blaquewithaq
approved these changes
Jan 19, 2024
Since the application will crash due to either heap corruption or double-free issues, it won't make much sense to allow people to compile it against affected versions.
Some Poco installations seem to not properly resolve component dependencies, so we play it safe and just add all components we require.
kblaschke
force-pushed
the
check-poco-version
branch
from
83f5deb
to
854eeba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the application will crash due to either heap corruption or double-free issues, it won't make much sense to allow people to compile it against affected versions.