feat(htpasswd): add autoreload for htpasswd

[vooon]

What type of PR is this?

feature

Which issue does this PR fix:

Fix #2925

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[vooon]

Unsure, htpasswd change do not require full reload with server restarts. But putting the logic into existing watcher much easier.
And in my case the event is not very often.

[vooon]

Looks like it works, but not as fast as file updates.

[codecov]

Codecov Report

Attention: Patch coverage is 71.25749% with 48 lines in your changes missing coverage. Please review.

Project coverage is 90.95%. Comparing base (528c2e5) to head (7b1a4d2).

Files with missing lines	Patch %	Lines
pkg/api/htpasswd.go	69.67%	30 Missing and 7 partials ⚠️
pkg/api/controller.go	45.00%	8 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2933      +/-   ##
==========================================
- Coverage   91.07%   90.95%   -0.12%     
==========================================
  Files         174      175       +1     
  Lines       32666    32798     +132     
==========================================
+ Hits        29749    29830      +81     
- Misses       2205     2246      +41     
- Partials      712      722      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rchincha]

Ideally, we need the watching logic to move outside the server/controller logic, so it is just another config file we watch (along with zot config)

That could be second step. Let other folks take a look also.

[andaaron]

Looks like it works, but not as fast as file updates.

What do you mean by file updates?

[vooon]

@andaaron i mean the delay observed after file write.

[andaaron]

@andaaron i mean the delay observed after file write.

If a separate watcher is an improvement, I think we should go for it. It doesn't make sense to restart the whole server for a new user.

[vooon]

@andaaron i've added separate watcher. Need to test it, and also write some tests, but I'm more used to testify...