handle read error on iterating sortdb

project-tsurugi · Jul 23, 2024 · f72c67e · f72c67e
1 parent dd126b7
commit f72c67e
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/limestone/sortdb_wrapper.h b/src/limestone/sortdb_wrapper.h
@@ -90,13 +90,16 @@ class sortdb_wrapper {
     }
 
     void each(const std::function<void(std::string_view, std::string_view)>& fun) {
-        Iterator* it = sortdb_->NewIterator(ReadOptions());  // NOLINT (typical usage of API)
+        std::unique_ptr<Iterator> it{sortdb_->NewIterator(ReadOptions())};
         for (it->SeekToFirst(); it->Valid(); it->Next()) {
             Slice key = it->key();
             Slice value = it->value();
             fun(std::string_view(key.data(), key.size()), std::string_view(value.data(), value.size()));
         }
-        delete it;  // NOLINT (typical usage of API)
+        if (!it->status().ok()) {
+            LOG_LP(ERROR) << "sortdb iterator invalidated, status: " << it->status().ToString();
+            throw std::runtime_error("error in sortdb read iteration");
+        }
     }
 
 private: