Refactor code to address clang-tidy warnings

src/limestone/compaction_options.h

@@ -26,14 +26,14 @@
  namespace limestone::internal {
 
  class compaction_options {
- public:
+  public:
      // Constructor: Pre-compaction phase where to_dir is not provided.
      // File set is provided and GC is disabled.
      // In this constructor, "/not_exists_dir" is set for to_dir to indicate an error if used.
      compaction_options(
          const boost::filesystem::path& from,
          int workers,
-         std::set<std::string> file_names
+         const std::set<std::string>& file_names
      )
      : from_dir_(from),
        to_dir_("/not_exists_dir"),
@@ -52,7 +52,6 @@
      : from_dir_(from),
        to_dir_(to),
        num_worker_(workers),
-       file_names_(),
        has_file_set_(false),
        gc_snapshot_(std::nullopt)
      {}
@@ -62,7 +61,7 @@
          const boost::filesystem::path& from,
          const boost::filesystem::path& to,
          int workers,
-         std::set<std::string> file_names
+         const std::set<std::string>& file_names
      )
      : from_dir_(from),
        to_dir_(to),
@@ -78,7 +77,7 @@
          const boost::filesystem::path& from,
          const boost::filesystem::path& to,
          int workers,
-         std::set<std::string> file_names,
+         const std::set<std::string>& file_names,
          blob_file_gc_snapshot& gc_snapshot
      )
      : from_dir_(from),
@@ -89,35 +88,35 @@
        gc_snapshot_(std::ref(gc_snapshot))
      {}
 
-     // Getter for from_dir
-     const boost::filesystem::path& get_from_dir() const { return from_dir_; }
+     // Getter for from_dir.
+     [[nodiscard]] const boost::filesystem::path& get_from_dir() const { return from_dir_; }
 
      // Getter for to_dir.
-     const boost::filesystem::path& get_to_dir() const { return to_dir_; }
+     [[nodiscard]] const boost::filesystem::path& get_to_dir() const { return to_dir_; }
 
      // Getter for num_worker.
-     int get_num_worker() const { return num_worker_; }
+     [[nodiscard]] int get_num_worker() const { return num_worker_; }
 
      // Getter for file_names.
-     const std::set<std::string>& get_file_names() const { return file_names_; }
+     [[nodiscard]] const std::set<std::string>& get_file_names() const { return file_names_; }
 
      // Returns true if a file set is configured.
-     bool has_file_set() const { return has_file_set_; }
+     [[nodiscard]] bool has_file_set() const { return has_file_set_; }
 
      // Check if GC is enabled.
-     bool is_gc_enabled() const { return gc_snapshot_.has_value(); }
+     [[nodiscard]] bool is_gc_enabled() const { return gc_snapshot_.has_value(); }
 
      // Getter for gc_snapshot.
      // It is caller's responsibility to ensure GC is enabled before calling.
-     blob_file_gc_snapshot& get_gc_snapshot() const { return gc_snapshot_.value().get(); }
+     [[nodiscard]] blob_file_gc_snapshot& get_gc_snapshot() const { return gc_snapshot_.value().get(); }
 
- private:
+  private:
      // Basic compaction settings.
      boost::filesystem::path from_dir_;
      boost::filesystem::path to_dir_;
      int num_worker_;
 
-    // File set for compaction
+     // File set for compaction.
      std::set<std::string> file_names_;
      bool has_file_set_;