Skip to content
Limestone-CI

Refactor code to address clang-tidy warnings #952

Sign in to view logs

Refactor code to address clang-tidy warnings

Refactor code to address clang-tidy warnings #952

Triggered via push February 18, 2025 07:51
@umeganeumegane
pushed 31ffbc8
wip/blob
Status Failure
Total duration 1m 20s
Artifacts –

ci-build.yml

on: push
Analysis
1m 9s
Analysis
Matrix: Build
Fit to window
Zoom out
Zoom in

Annotations

1 error and 22 warnings
Analysis
modernize-use-nodiscard: src/limestone/compaction_options.h#L92
function 'get_from_dir' should be marked [[nodiscard]]
modernize-use-nodiscard: src/limestone/compaction_options.h#L95
function 'get_to_dir' should be marked [[nodiscard]]
modernize-use-nodiscard: src/limestone/compaction_options.h#L98
function 'get_num_worker' should be marked [[nodiscard]]
modernize-use-nodiscard: src/limestone/compaction_options.h#L101
function 'get_file_names' should be marked [[nodiscard]]
modernize-use-nodiscard: src/limestone/compaction_options.h#L104
function 'has_file_set' should be marked [[nodiscard]]
modernize-use-nodiscard: src/limestone/compaction_options.h#L107
function 'is_gc_enabled' should be marked [[nodiscard]]
modernize-use-nodiscard: src/limestone/compaction_options.h#L111
function 'get_gc_snapshot' should be marked [[nodiscard]]
modernize-pass-by-value: src/limestone/dblog_scan.h#L86
pass by value and use std::move
modernize-pass-by-value: src/limestone/dblog_scan.h#L98
pass by value and use std::move
performance-unnecessary-value-param: src/limestone/dblog_scan.h#L98
the parameter 'options' is copied for each invocation but only used as a const reference; consider making it a const reference
modernize-use-nodiscard: src/./limestone/compaction_options.h#L92
function 'get_from_dir' should be marked [[nodiscard]]
modernize-use-nodiscard: src/./limestone/compaction_options.h#L95
function 'get_to_dir' should be marked [[nodiscard]]
modernize-use-nodiscard: src/./limestone/compaction_options.h#L98
function 'get_num_worker' should be marked [[nodiscard]]
modernize-use-nodiscard: src/./limestone/compaction_options.h#L101
function 'get_file_names' should be marked [[nodiscard]]
modernize-use-nodiscard: src/./limestone/compaction_options.h#L104
function 'has_file_set' should be marked [[nodiscard]]
modernize-use-nodiscard: src/./limestone/compaction_options.h#L107
function 'is_gc_enabled' should be marked [[nodiscard]]
modernize-use-nodiscard: src/./limestone/compaction_options.h#L111
function 'get_gc_snapshot' should be marked [[nodiscard]]
modernize-pass-by-value: src/./limestone/dblog_scan.h#L86
pass by value and use std::move
modernize-pass-by-value: src/./limestone/dblog_scan.h#L98
pass by value and use std::move
performance-unnecessary-value-param: src/./limestone/dblog_scan.h#L98
the parameter 'options' is copied for each invocation but only used as a const reference; consider making it a const reference
performance-unnecessary-value-param: src/limestone/datastore_snapshot.cpp#L303
the parameter 'options' is copied for each invocation but only used as a const reference; consider making it a const reference
performance-unnecessary-copy-initialization: src/limestone/datastore_snapshot.cpp#L307
the variable 'to_dir' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference