RC Update Optimization: Inst should be added to the NCQ in all cases;…

… Commit shouldn't check if the NCQ is full or not Change-Id: I139044648c4371af0db35a99a338087db01e0339
project-starch · Oct 4, 2023 · fd39fd5 · fd39fd5
1 parent d7ce7c9
commit fd39fd5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/arch/riscvcapstone/o3/commit.cc b/src/arch/riscvcapstone/o3/commit.cc
@@ -1239,10 +1239,10 @@ Commit::commitHead(const DynInstPtr &head_inst, unsigned inst_num)
         mnemonic != "shrink" &&
         head_inst->numDestRegs() > 0) {
 
-        if(iewStage->ncQueue.isFull(tid)) {
-            DPRINTF(Commit, "[tid:%i] NCQ has become full.\n", tid);
-            return false;
-        }
+        // if(iewStage->ncQueue.isFull(tid)) {
+        //     DPRINTF(Commit, "[tid:%i] NCQ has become full.\n", tid);
+        //     return false;
+        // }
 
         CPU* cpu = dynamic_cast<o3::CPU *>(head_inst->getCpuPtr());
         PhysRegIdPtr prev_reg = head_inst->prevDestIdx(0); //FIXME: this may be 0, may not be 0

diff --git a/src/arch/riscvcapstone/o3/iew.cc b/src/arch/riscvcapstone/o3/iew.cc
@@ -1009,7 +1009,7 @@ IEW::dispatchInsts(ThreadID tid)
         }
 
         // Check NSQ
-        if(inst->hasNodeOp() && ncQueue.isFull(tid)) {
+        if(ncQueue.isFull(tid)) {
             DPRINTF(IEW, "[tid:%i] Issue: NCQ has become full.\n", tid);
             DPRINTF(NCQ, "[tid:%i] NCQ has become full.\n", tid);
             block(tid);