Skip to content

Commit

Permalink
ci: Add alpine:edge image to those cloned and use it in test.
Browse files Browse the repository at this point in the history
The alpine image being used for the sbom test was already being
used (and cloned).  There is no reason to depend on ghcr.io for it.

Signed-off-by: Scott Moser <[email protected]>
  • Loading branch information
smoser committed Nov 27, 2023
1 parent 8246e2e commit 38acadd
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
9 changes: 6 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,13 @@ build_stacker = go build $1 -tags "$(BUILD_TAGS) $2" -ldflags "-X main.version=$
# See doc/hacking.md for how to use a local oci or docker repository.
STACKER_DOCKER_BASE?=docker://ghcr.io/project-stacker/
# They default to their image name in STACKER_DOCKER_BASE
STACKER_BUILD_BASE_IMAGE?=$(STACKER_DOCKER_BASE)alpine:edge
STACKER_BUILD_BASE_IMAGE?=$(STACKER_BUILD_ALPINE_IMAGE)
STACKER_BUILD_ALPINE_IMAGE?=$(STACKER_DOCKER_BASE)alpine:edge
STACKER_BUILD_BUSYBOX_IMAGE?=$(STACKER_DOCKER_BASE)busybox:latest
STACKER_BUILD_CENTOS_IMAGE?=$(STACKER_DOCKER_BASE)centos:latest
STACKER_BUILD_UBUNTU_IMAGE?=$(STACKER_DOCKER_BASE)ubuntu:latest
STACKER_BUILD_IMAGES = \
$(STACKER_BUILD_ALPINE_IMAGE) \
$(STACKER_BUILD_BASE_IMAGE) \
$(STACKER_BUILD_BUSYBOX_IMAGE) \
$(STACKER_BUILD_CENTOS_IMAGE) \
Expand Down Expand Up @@ -149,7 +151,7 @@ test: stacker $(REGCLIENT) $(SKOPEO) $(ZOT)
sudo -E PATH="$$PATH" \
LXC_BRANCH=$(LXC_BRANCH) \
LXC_CLONE_URL=$(LXC_CLONE_URL) \
STACKER_BUILD_BASE_IMAGE=$(STACKER_BUILD_BASE_IMAGE) \
STACKER_BUILD_ALPINE_IMAGE=$(STACKER_BUILD_ALPINE_IMAGE) \
STACKER_BUILD_BUSYBOX_IMAGE=$(STACKER_BUILD_BUSYBOX_IMAGE) \
STACKER_BUILD_CENTOS_IMAGE=$(STACKER_BUILD_CENTOS_IMAGE) \
STACKER_BUILD_UBUNTU_IMAGE=$(STACKER_BUILD_UBUNTU_IMAGE) \
Expand All @@ -166,7 +168,8 @@ test-cov: stacker-cov $(REGCLIENT) $(SKOPEO) $(ZOT)
-E GOCOVERDIR="$$GOCOVERDIR" \
LXC_BRANCH=$(LXC_BRANCH) \
LXC_CLONE_URL=$(LXC_CLONE_URL) \
STACKER_BUILD_BASE_IMAGE=$(STACKER_BUILD_BASE_IMAGE) \
STACKER_BUILD_ALPINE_IMAGE=$(STACKER_BUILD_ALPINE_IMAGE) \
STACKER_BUILD_BUSYBOX_IMAGE=$(STACKER_BUILD_BUSYBOX_IMAGE) \
STACKER_BUILD_CENTOS_IMAGE=$(STACKER_BUILD_CENTOS_IMAGE) \
STACKER_BUILD_UBUNTU_IMAGE=$(STACKER_BUILD_UBUNTU_IMAGE) \
./test/main.py \
Expand Down
4 changes: 2 additions & 2 deletions test/bom.bats
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,8 @@ EOF
cat > stacker.yaml <<EOF
bom-alpine:
from:
type: docker
url: docker://ghcr.io/project-stacker/alpine:edge
type: oci
url: $ALPINE_OCI
bom:
generate: true
packages:
Expand Down
1 change: 1 addition & 0 deletions test/helpers.bash
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ STACKER_BUILD_UBUNTU_IMAGE=${STACKER_BUILD_UBUNTU_IMAGE:-${STACKER_DOCKER_BASE}u
) 9<$ROOT_DIR/test/main.py
export BUSYBOX_OCI="$ROOT_DIR/test/busybox:latest"
export CENTOS_OCI="$ROOT_DIR/test/centos:latest"
export ALPINE_OCI="$ROOT_DIR/test/alpine:edge"
export UBUNTU_OCI="$ROOT_DIR/test/ubuntu:latest"
export PATH="$PATH:$ROOT_DIR/hack/tools/bin"

Expand Down

0 comments on commit 38acadd

Please sign in to comment.