Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a generic spin loader #389

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add a generic spin loader #389

wants to merge 3 commits into from

Conversation

aaravlu
Copy link
Contributor

@aaravlu aaravlu commented Feb 12, 2025 •
edited
Loading

issue: #387
Spin loader's size could follow its View's size:
Screencast from 2025-02-12 13-09-29.webm

@aaravlu aaravlu marked this pull request as ready for review February 12, 2025 05:11
@aaravlu aaravlu added the waiting-on-review This issue is waiting to be reviewed label Feb 12, 2025
ZhangHanDong
ZhangHanDong reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@ZhangHanDong ZhangHanDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RobrixSpinLoader component is essentially well-designed to provide a dynamic spinning loading effect. With some optimizations and flexibility enhancements, such as adding dynamic transparency, configurable segment count, and rotation speed control, it can be made more customizable and efficient. Additionally, considering performance, the calculation process can be further streamlined to avoid unnecessary complex calculations during animation frames.

src/shared/styles.rs Outdated Show resolved Hide resolved
src/shared/styles.rs Outdated Show resolved Hide resolved
src/shared/styles.rs Outdated Show resolved Hide resolved
src/shared/styles.rs Outdated Show resolved Hide resolved
@ZhangHanDong ZhangHanDong added waiting-on-author This issue is waiting on the original author for a response and removed waiting-on-review This issue is waiting to be reviewed labels Feb 13, 2025
@aaravlu aaravlu requested a review from kevinaboos February 14, 2025 02:07
@aaravlu aaravlu added waiting-on-review This issue is waiting to be reviewed and removed waiting-on-author This issue is waiting on the original author for a response labels Feb 14, 2025
@aaravlu
Copy link
Contributor Author

aaravlu commented Feb 14, 2025

15 segments with 0.1 speed:
Screencast from 2025-02-14 10-09-56.webm

5 segments with 1.0 speed:
Screencast from 2025-02-14 10-10-40.webm

@ZhangHanDong
Copy link
Contributor

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhangHanDong ZhangHanDong ZhangHanDong left review comments

@alanpoon alanpoon Awaiting requested review from alanpoon

@kevinaboos kevinaboos Awaiting requested review from kevinaboos

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
waiting-on-review This issue is waiting to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaravlu @ZhangHanDong