Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thumbnail #352

Merged
merged 4 commits into from
Jan 26, 2025
Merged

Fix thumbnail #352

merged 4 commits into from
Jan 26, 2025

Conversation

aaravlu
Copy link
Contributor

@aaravlu aaravlu commented Jan 26, 2025

We must apply the thumbnail format for the image anyhow it possess a thumbnail source or not.

Btw, an image won't possess a thumbnail source unless its size is larger than 500KB or so, by my test.

before:

Screenshot from 2025-01-26 21-04-46

after:

Screenshot from 2025-01-26 22-48-31


Btw, an image won't possess a thumbnail source unless its size is larger than 500KB or so, by my test.

I found this by accident on deving, you can take a look (notice the size I marked)
Screenshot from 2025-01-26 21-15-48

@aaravlu aaravlu requested a review from kevinaboos January 26, 2025 14:54
@aaravlu aaravlu added the waiting-on-review This issue is waiting to be reviewed label Jan 26, 2025
@aaravlu aaravlu self-assigned this Jan 26, 2025
Copy link
Member

@kevinaboos kevinaboos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Always good to save bandwidth with thumbnail.

@kevinaboos kevinaboos removed the waiting-on-review This issue is waiting to be reviewed label Jan 26, 2025
@kevinaboos kevinaboos merged commit d22aa98 into project-robius:main Jan 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants