Add unread highlighting mentions in the RoomPreview when a user menti… #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinaboos
requested changes
Jan 24, 2025
kevinaboos
added
the
waiting-on-author
kevinaboos
requested changes
Jan 25, 2025
There was a problem hiding this comment.
Oops, i forgot to check the code closely the first time. Sorry, I was distracted.
It seems like the key part of the logic is missing -- you're not actually displaying the number of unread mentions. You're only changing the color.
The logic should be:
- if num_unread_mentions > 0, make the badge color red and display the number of unread mentions.
- else if num_unread_messages > 0, make the badge gray and display the number of unread messages
- else hide the badge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the unread messages change, the num_unread_mentions value is also passed. If this value is greater than 0, the badge is displayed in red; otherwise, it is shown in gray.
issue: #329