This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
Generate HTML for sum8 ILA capture #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satnam6502
force-pushed
the
plt2
branch
3 times, most recently
from
5842b1b to
ce1f230
Compare
jadephilipoom
approved these changes
May 17, 2021
There was a problem hiding this comment.
LGTM. I left some comments on #718, but fine to merge as-is.
blaxill
suggested changes
May 17, 2021
cava/Cava2HDL/Makefile
Outdated
| @@ -20,6 +20,9 @@ all: haskell | |||
|
|
|||
| haskell: | |||
| cabal build | |||
| runhaskell Setup.hs configure --user | |||
| runhaskell Setup.hs build | |||
| runhaskell Setup.hs install | |||
There was a problem hiding this comment.
I don't think Setup.hs is required? Were you seeing issues without it?
There was a problem hiding this comment.
How would I do it without Setup.hs?
There was a problem hiding this comment.
With the cabal setup, installing is not required. cabal repl should work directly to get a ghci prompt with the files loaded.
There was a problem hiding this comment.
Well, I don't want to use cabal repl! OK... I am going to do your bidding and remove these lines and use cabal repl :-(
Co-authored-by: jadephilipoom <[email protected]>
|
@blaxill PTAL, thank you kindly. |
blaxill
approved these changes
May 17, 2021
Ah! Right! Done! Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation to show the implementation of the sum of sequence circuit, its simulation and its execution on an FPGA board. Also fix the generation of the Cava2HDL library #784