Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make produces type match disposes #688

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make produces type match disposes #688

wants to merge 1 commit into from

Conversation

dwalluck
Copy link
Collaborator

No description provided.

@dwalluck
Copy link
Collaborator Author

I am not sure if this is a problem or not, but I found it strange that the produces and disposes types do not (exactly) match. While @Produces is a ClientSession, @Disposes is a KojiClientSession.

It doesn't seem possible to make them both a ClientSession, so maybe making them both a KojiClientSession is better?

@dwalluck dwalluck requested review from jbartece and janinko and removed request for goldmann and vibe13 August 28, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbartece jbartece Awaiting requested review from jbartece

@janinko janinko Awaiting requested review from janinko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dwalluck