-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Group Chats #772
base: master
Are you sure you want to change the base?
Refactor Group Chats #772
Conversation
One problem I just thought about will be groups that were created before this and don't have the "createdBy" defined, I could make it so any groups that don't have that will allow any member to remove another member. I also don't know if any errors will be created if "createdBy" is left blank |
Tested with no createBy date, everything still works however no one can remove people (may add it so everyone can remove in the future). Also just added leaving groups |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, only issue I have is that members cannot re-join a group and a few minor things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple small things I noticed that might need some cleanup but all in all good work, thank you for the PR :)
phone/src/apps/messages/components/form/NewMessageGroupForm.tsx
Outdated
Show resolved
Hide resolved
Just need to do some last testing but this should be finished, @Mojito-Fivem would you prefer I do a separate PR for adding members to groups or keep it here |
It's all under the same feature and I think it would create more issues having this without the adding members functionality |
Added system messages The following SQL is now needed (added to the original message) ALTER TABLE npwd_messages ADD COLUMN `is_system` tinyint(4) NOT NULL DEFAULT 0;
ALTER TABLE npwd_messages ADD COLUMN `system_type` varchar(48) NOT NULL DEFAULT '';
ALTER TABLE npwd_messages ADD COLUMN `system_number` varchar(48) NOT NULL DEFAULT ''; |
Will there not be any chance of group calling? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
this needs to be revived 😢 |
Pull Request Description
A full rework of the group system
Feature Specs:
Tasks Progress:
Preview
The following SQL needs to be ran
#610
Pull Request Checklist: