docs: update tradeoffs section to reflect scanner independence (#818) #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradhans0906
requested review from
jeremyrickard,
sozercan and
ashnamehrotra
as code owners
ashnamehrotra
requested changes
Jan 14, 2025
|
@pradhans0906 thanks for the PR! Looks like commit needs sign-off for DCO check |
Updates the tradeoffs section in the design documentation to accurately reflect copa's ability to work with or without vulnerability scanner reports. The changes: - Remove outdated statements about scanner report dependencies - Clarify the package-based update model - Maintain information about package manager dependencies and platform limitations - Improve document structure for better readability # Changes - Replace outdated tradeoffs content with updated, accurate information - Add clearer section organization with numbered points - Update description of scanner integration to reflect optional usage Closes project-copacetic#818 Signed-off-by: swapnasagar pradhan <[email protected]>
…up (project-copacetic#889) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: swapnasagar pradhan <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: swapnasagar pradhan <[email protected]>
…copacetic#891) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: swapnasagar pradhan <[email protected]>
…acetic#892) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: swapnasagar pradhan <[email protected]>
…t-copacetic#893) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: swapnasagar pradhan <[email protected]>
Signed-off-by: swapnasagar pradhan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #888 +/- ##
=======================================
Coverage 46.98% 46.98%
=======================================
Files 18 18
Lines 2205 2205
=======================================
Hits 1036 1036
Misses 1111 1111
Partials 58 58 ☔ View full report in Codecov by Sentry. |
ashnamehrotra
requested changes
Jan 21, 2025
Comment on lines
+93
to
+94
| - Windows containers lack a standardized package upgrade mechanism and has limited Windows continer support |
There was a problem hiding this comment.
Suggested change
| - While BuildKit has experimental Windows container support | |
| - Windows containers lack a standardized package upgrade mechanism and has limited Windows continer support | |
| - While BuildKit has experimental Windows container support, Windows containers lack a standardized package upgrade mechanism |
There was a problem hiding this comment.
and same changes in other versioned docs
| 1. **Package-Based Update Model**: | ||
| - While Copa can work with or without vulnerability scanner reports, its patching capability is fundamentally based on OS package updates | ||
| - When using scanner reports, false positives/negatives from scanners flow downstream to copa |
There was a problem hiding this comment.
Suggested change
| - When using scanner reports, false positives/negatives from scanners flow downstream to copa | |
| - When using scanner reports, false positives/negatives from scanners flow downstream to Copa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the tradeoffs section in the design documentation to accurately reflect copa's ability to work with or without vulnerability scanner reports.
The changes:
Changes
Closes #818