fix: status grid UI was not re-rendering on model change

project-codeflare · Apr 10, 2023 · fe4d189 · fe4d189
1 parent 39cb8e2
commit fe4d189
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/plugins/plugin-codeflare-dashboard/src/components/Dashboard/index.tsx b/plugins/plugin-codeflare-dashboard/src/components/Dashboard/index.tsx
@@ -110,8 +110,9 @@ export default class Dashboard extends React.PureComponent<Props, State> {
           workers: !isWorkersUpdate(model)
             ? curState?.workers
             : !curState?.workers
-            ? [model.workers]
-            : [...curState.workers.slice(0, gridIdx), model.workers, ...curState.workers.slice(gridIdx + 1)],
+            ? [model.workers] // i think this is wrong. don't we need to preserve indexing?
+            : [...curState.workers.slice(0, gridIdx), model.workers.slice(), ...curState.workers.slice(gridIdx + 1)],
+          //                                                       ^^^^^^^ ugh, we could optimize this to check for changes
         })),
       0
     )