Skip to content

Commit

Permalink
ensure AppWrapper controller sets PodsReady condition on Workload (#180
Browse files Browse the repository at this point in the history
…) (#182)

Need to conservatively set the WaitForPodsReady option to true so that
the AppWrapper instance of Kueue's generic reconciller loop will set
the PodsReady condition on the Workload instance when pods become
ready.
  • Loading branch information
dgrove-oss authored Jun 28, 2024
1 parent aebdb4d commit 5147084
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkg/controller/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import (
"github.com/project-codeflare/appwrapper/internal/webhook"
"github.com/project-codeflare/appwrapper/pkg/config"

"sigs.k8s.io/kueue/apis/config/v1beta1"
"sigs.k8s.io/kueue/pkg/controller/jobframework"
)

Expand All @@ -43,6 +44,7 @@ func SetupControllers(mgr ctrl.Manager, awConfig *config.AppWrapperConfig) error
mgr.GetClient(),
mgr.GetEventRecorderFor("kueue"),
jobframework.WithManageJobsWithoutQueueName(true),
jobframework.WithWaitForPodsReady(&v1beta1.WaitForPodsReady{Enable: true}),
).SetupWithManager(mgr); err != nil {
return fmt.Errorf("workload controller: %w", err)
}
Expand Down

0 comments on commit 5147084

Please sign in to comment.