[Silabs] Fix the secure soc reset issue #37965
Open
+24
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #37965: Size comparison from 1114858 to 186c7c3 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37965: Size comparison from c1506f3 to c61c362 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
rosahay-silabs
approved these changes
Mar 12, 2025
|
PR #37965: Size comparison from c1506f3 to 12928c3 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Mar 12, 2025
| @@ -72,7 +73,7 @@ size_t pw_trace_GetTraceTimeTicksPerSecond() | |||
| } | |||
|
|
|||
| #endif // defined(PW_RPC_TRACING_SERVICE) && PW_RPC_TRACING_SERVICE | |||
|
|
|||
| using namespace chip::DeviceLayer::Silabs; | |||
There was a problem hiding this comment.
Suggested change
| using namespace chip::DeviceLayer::Silabs; | |
| using namespace chip::DeviceLayer::Silabs; | |
| @@ -42,7 +43,7 @@ extern "C" { | |||
|
|
|||
| uint8_t flag = RPS_HEADER; | |||
| static chip::OTAImageProcessorImpl gImageProcessor; | |||
|
|
|||
| using namespace chip::DeviceLayer::Silabs; | |||
There was a problem hiding this comment.
Suggested change
| using namespace chip::DeviceLayer::Silabs; | |
| using namespace chip::DeviceLayer::Silabs; | |
| @@ -56,6 +56,9 @@ class SilabsPlatformAbstractionBase | |||
| virtual CHIP_ERROR FlashErasePage(uint32_t addr) { return CHIP_ERROR_NOT_IMPLEMENTED; } | |||
| virtual CHIP_ERROR FlashWritePage(uint32_t addr, const uint8_t * data, size_t size) { return CHIP_ERROR_NOT_IMPLEMENTED; } | |||
|
|
|||
| // soft reset | |||
| virtual void SoftwareReset(void) {} | |||
There was a problem hiding this comment.
This can be pure virtual since it is a required function and can we add function comments?
| @@ -38,6 +38,8 @@ extern "C" { | |||
| #endif // SL_SI91X_BOARD_INIT | |||
| #include "sl_event_handler.h" | |||
|
|
|||
| #include "sl_si91x_hal_soc_soft_reset.h" | |||
There was a problem hiding this comment.
Does it need to be an extern C include?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
####Description
The goal of this PR to fix soft reset issue with secure 917 SoC board. While factory reset
NVIC_SystemReset()API is called but it is observed that it is stuck in this API for secure SoC boards.As this issue has been solved in wifi-sdk reset call
sl_si91x_soc_nvic_resetfor 917 SoC boards . So added SPAM reset API to call specific reset API based on platform instance.EFR platforms - NVIC_SystemReset
917 SoC platforms - sl_si91x_soc_nvic_reset
Testing
Verified on EFR and 917 SoC platform by doing factory reset and it is resetting properly.