legacy flag added #37921
Open
legacy flag added #37921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #37921: Size comparison from c62d534 to 996dd70 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37921: Size comparison from c62d534 to 4ecf278 Increases above 0.2%:
Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37921: Size comparison from f4260df to 215a08f Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37921: Size comparison from 98a55fe to ca570c9 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37921: Size comparison from b56134c to 0b63690 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37921: Size comparison from 0bae36f to b29708c Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
r-recchia
force-pushed
the
legacy-test-triggers
branch
from
b29708c to
79f2351
Compare
|
PR #37921: Size comparison from 1114858 to 79f2351 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR of issue #389. It addresses the bullets 1 and 3 listed in the issue.
This PR updates
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py. It adds a validation in thesend_test_event_triggersfunction. This function verifies if the user executed the test with the--use-legacy-test-event-triggersflag. If the flag is not set, then the event trigger variable will be updated with the--endpointvalue as the [specification] (https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/testeventtrigger_overview.adoc) details. If the flag is set then the target endpoint remains as 0.Testing
In the first terminal:
rm /tmp/chip_*In the second terminal:
When running the test I added flags
--endpoint <endpoint>and--use-legacy-test-event-triggersto check expected outcome.