Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of WebRTC Provider cluster (Phase I) #37767

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Initial implementation of WebRTC Provider cluster (Phase I) #37767

wants to merge 24 commits into from

Conversation

yufengwangca
Copy link
Contributor

@yufengwangca yufengwangca commented Feb 25, 2025 •
edited
Loading

This is the initial implementation of WebRTC Provider cluster

  • Delegate definition
  • Attributes support
  • Command Handling

Testing

For easier review, delegate implementation in the example app and Python tests will be in a separate PR.

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Feb 25, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  src/app/zap_cluster_list.json  75% smaller
  examples/camera-app/camera-common/camera-app.matter Unsupported file format
  examples/camera-app/camera-common/camera-app.zap Unsupported file format
  scripts/tools/check_includes_config.py  0% smaller
  src/app/clusters/webrtc-transport-provider-server/webrtc-transport-provider-server.cpp Unsupported file format
  src/app/clusters/webrtc-transport-provider-server/webrtc-transport-provider-server.h Unsupported file format
  src/app/common/templates/config-data.yaml  0% smaller
  zzz_generated/app-common/app-common/zap-generated/callback.h Unsupported file format

@yufengwangca yufengwangca changed the title Initial implementation of WebRTC Provider cluster Initial implementation of WebRTC Provider cluster (Phase I) Feb 25, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

PR #37767: Size comparison from ba98125 to 9ef70eb

Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section ba98125 9ef70eb change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1096628 1096628 0 0.0
RAM 94842 94842 0 0.0
bl702 lighting-app bl702+eth FLASH 651606 651606 0 0.0
RAM 33509 33509 0 0.0
bl702+wifi FLASH 828878 828878 0 0.0
RAM 22233 22233 0 0.0
bl706+mfd+rpc+littlefs FLASH 1061274 1061274 0 0.0
RAM 32157 32157 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 892118 892118 0 0.0
RAM 26896 26896 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 975014 975014 0 0.0
RAM 24644 24644 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 815300 815300 0 0.0
RAM 120256 120256 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 824220 824220 0 0.0
RAM 125352 125352 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771080 771080 0 0.0
RAM 113724 113724 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755364 755364 0 0.0
RAM 113932 113932 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538842 538842 0 0.0
RAM 205112 205112 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572998 572998 0 0.0
RAM 205360 205360 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 656429 656429 0 0.0
RAM 75324 75324 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 676289 676289 0 0.0
RAM 77964 77964 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 676289 676289 0 0.0
RAM 77964 77964 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 633213 633213 0 0.0
RAM 70392 70392 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616293 616293 0 0.0
RAM 71532 71532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635929 635929 0 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635929 635929 0 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635789 635789 0 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655513 655513 0 0.0
RAM 77084 77084 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655513 655513 0 0.0
RAM 77084 77084 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 612137 612137 0 0.0
RAM 68628 68628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631997 631997 0 0.0
RAM 71268 71268 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631997 631997 0 0.0
RAM 71268 71268 0 0.0
efr32 lock-app BRD4187C FLASH 939536 939536 0 0.0
RAM 159920 159920 0 0.0
BRD4338a FLASH 732536 732536 0 0.0
RAM 234828 234828 0 0.0
window-app BRD4187C FLASH 1032000 1032000 0 0.0
RAM 128024 128024 0 0.0
esp32 all-clusters-app c3devkit DRAM 97312 97312 0 0.0
FLASH 1582004 1582004 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116108 116108 0 0.0
FLASH 1550014 1550014 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4720 4720 0 0.0
FLASH 2649887 2649887 0 0.0
RAM 111088 111088 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 5921360 5921360 0 0.0
RAM 513712 513712 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5266394 5266394 0 0.0
RAM 221112 221112 0 0.0
bridge-app debug unknown 5440 5440 0 0.0
FLASH 4625036 4625036 0 0.0
RAM 199816 199816 0 0.0
camera-app debug unknown 5424 5424 0 0.0
FLASH 4671816 4672448 632 0.0
RAM 194592 194752 160 0.1
chip-tool debug unknown 6096 6096 0 0.0
FLASH 13302351 13302351 0 0.0
RAM 603392 603392 0 0.0
chip-tool-ipv6only arm64 unknown 21976 21976 0 0.0
FLASH 11495416 11495416 0 0.0
RAM 656112 656112 0 0.0
fabric-admin debug unknown 5784 5784 0 0.0
FLASH 11567249 11567249 0 0.0
RAM 603176 603176 0 0.0
fabric-bridge-app debug unknown 4688 4688 0 0.0
FLASH 4452254 4452254 0 0.0
RAM 187016 187016 0 0.0
fabric-sync debug unknown 4944 4944 0 0.0
FLASH 5569205 5569205 0 0.0
RAM 470400 470400 0 0.0
lighting-app debug+rpc+ui unknown 6152 6152 0 0.0
FLASH 5515489 5515489 0 0.0
RAM 203952 203952 0 0.0
lock-app debug unknown 5392 5392 0 0.0
FLASH 4688504 4688504 0 0.0
RAM 191144 191144 0 0.0
ota-provider-app debug unknown 4728 4728 0 0.0
FLASH 4310684 4310684 0 0.0
RAM 179832 179832 0 0.0
ota-requestor-app debug unknown 4680 4680 0 0.0
FLASH 4440810 4440810 0 0.0
RAM 184320 184320 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 2949196 2949196 0 0.0
RAM 143672 143672 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4138392 4138392 0 0.0
RAM 229016 229016 0 0.0
tv-app debug unknown 5720 5720 0 0.0
FLASH 5908117 5908117 0 0.0
RAM 593832 593832 0 0.0
tv-casting-app debug unknown 5296 5296 0 0.0
FLASH 11472829 11472829 0 0.0
RAM 718656 718656 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907708 907708 0 0.0
RAM 142323 142323 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901788 901788 0 0.0
RAM 124663 124663 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846312 846312 0 0.0
RAM 141251 141251 0 0.0
nxp contact k32w0+release FLASH 585256 585256 0 0.0
RAM 70876 70876 0 0.0
mcxw71+release FLASH 600712 600712 0 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 611196 611196 0 0.0
RAM 70164 70164 0 0.0
k32w1+release FLASH 685680 685680 0 0.0
RAM 48584 48584 0 0.0
lock mcxw71+release FLASH 749536 749536 0 0.0
RAM 67500 67500 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646188 1646188 0 0.0
RAM 211472 211472 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552956 1552956 0 0.0
RAM 208288 208288 0 0.0
light cy8ckit_062s2_43012 FLASH 1438644 1438644 0 0.0
RAM 197040 197040 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467516 1467516 0 0.0
RAM 224704 224704 0 0.0
qpg lighting-app qpg6105+debug FLASH 662188 662188 0 0.0
RAM 105116 105116 0 0.0
lock-app qpg6105+debug FLASH 620304 620304 0 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 459832 459832 0 0.0
RAM 141472 141472 0 0.0
telink bridge-app tl7218x FLASH 665034 665034 0 0.0
RAM 90728 90728 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622078 622078 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 745218 745218 0 0.0
RAM 40396 40396 0 0.0
tl7218x FLASH 753780 753780 0 0.0
RAM 97540 97540 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680850 680850 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709412 709412 0 0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 600592 600592 0 0.0
RAM 138812 138812 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 788820 788820 0 0.0
RAM 96388 96388 0 0.0
tizen all-clusters-app arm unknown 5076 5076 0 0.0
FLASH 1750852 1750852 0 0.0
RAM 93260 93260 0 0.0
chip-tool-ubsan arm unknown 11492 11492 0 0.0
FLASH 18983694 18983694 0 0.0
RAM 8306240 8306240 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

PR #37767: Size comparison from ba98125 to 8d76698

Increases above 0.2%:

platform target config section ba98125 8d76698 change % change
tizen all-clusters-app arm unknown 5076 5104 28 0.6
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section ba98125 8d76698 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1096628 1096628 0 0.0
RAM 94842 94842 0 0.0
bl702 lighting-app bl702+eth FLASH 651606 651606 0 0.0
RAM 33509 33509 0 0.0
bl702+wifi FLASH 828878 828878 0 0.0
RAM 22233 22233 0 0.0
bl706+mfd+rpc+littlefs FLASH 1061274 1061274 0 0.0
RAM 32157 32157 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 892118 892118 0 0.0
RAM 26896 26896 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 975014 975014 0 0.0
RAM 24644 24644 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 815300 815300 0 0.0
RAM 120256 120256 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 824220 824220 0 0.0
RAM 125352 125352 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771080 771080 0 0.0
RAM 113724 113724 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755364 755364 0 0.0
RAM 113932 113932 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538842 538842 0 0.0
RAM 205112 205112 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572998 572998 0 0.0
RAM 205360 205360 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 656429 656429 0 0.0
RAM 75324 75324 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 676289 676289 0 0.0
RAM 77964 77964 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 676289 676289 0 0.0
RAM 77964 77964 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 633213 633213 0 0.0
RAM 70392 70392 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616293 616293 0 0.0
RAM 71532 71532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635929 635929 0 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635929 635929 0 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635789 635789 0 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655513 655513 0 0.0
RAM 77084 77084 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655513 655513 0 0.0
RAM 77084 77084 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 612137 612137 0 0.0
RAM 68628 68628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631997 631997 0 0.0
RAM 71268 71268 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631997 631997 0 0.0
RAM 71268 71268 0 0.0
efr32 lock-app BRD4187C FLASH 939536 939536 0 0.0
RAM 159920 159920 0 0.0
BRD4338a FLASH 732536 732536 0 0.0
RAM 234828 234828 0 0.0
window-app BRD4187C FLASH 1032000 1032000 0 0.0
RAM 128024 128024 0 0.0
esp32 all-clusters-app c3devkit DRAM 97312 97312 0 0.0
FLASH 1582004 1582004 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116108 116108 0 0.0
FLASH 1550014 1550014 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4720 4728 8 0.2
FLASH 2649887 2650031 144 0.0
RAM 111088 111088 0 0.0
all-clusters-app debug unknown 5528 5536 8 0.1
FLASH 5921360 5921536 176 0.0
RAM 513712 513712 0 0.0
all-clusters-minimal-app debug unknown 5424 5432 8 0.1
FLASH 5266394 5266570 176 0.0
RAM 221112 221112 0 0.0
bridge-app debug unknown 5440 5448 8 0.1
FLASH 4625036 4625212 176 0.0
RAM 199816 199816 0 0.0
camera-app debug unknown 5424 5432 8 0.1
FLASH 4671816 4672624 808 0.0
RAM 194592 194752 160 0.1
chip-tool debug unknown 6096 6096 0 0.0
FLASH 13302351 13302351 0 0.0
RAM 603392 603392 0 0.0
chip-tool-ipv6only arm64 unknown 21976 21976 0 0.0
FLASH 11495416 11495416 0 0.0
RAM 656112 656112 0 0.0
fabric-admin debug unknown 5784 5784 0 0.0
FLASH 11567249 11567249 0 0.0
RAM 603176 603176 0 0.0
fabric-bridge-app debug unknown 4688 4696 8 0.2
FLASH 4452254 4452430 176 0.0
RAM 187016 187016 0 0.0
fabric-sync debug unknown 4944 4952 8 0.2
FLASH 5569205 5569381 176 0.0
RAM 470400 470400 0 0.0
lighting-app debug+rpc+ui unknown 6152 6160 8 0.1
FLASH 5515489 5515665 176 0.0
RAM 203952 203952 0 0.0
lock-app debug unknown 5392 5400 8 0.1
FLASH 4688504 4688680 176 0.0
RAM 191144 191144 0 0.0
ota-provider-app debug unknown 4728 4736 8 0.2
FLASH 4310684 4310860 176 0.0
RAM 179832 179832 0 0.0
ota-requestor-app debug unknown 4680 4688 8 0.2
FLASH 4440810 4440986 176 0.0
RAM 184320 184320 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 2949196 2949196 0 0.0
RAM 143672 143672 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4138392 4138536 144 0.0
RAM 229016 229016 0 0.0
tv-app debug unknown 5720 5728 8 0.1
FLASH 5908117 5908261 144 0.0
RAM 593832 593832 0 0.0
tv-casting-app debug unknown 5296 5304 8 0.2
FLASH 11472829 11472973 144 0.0
RAM 718656 718656 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907708 907708 0 0.0
RAM 142323 142323 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901788 901788 0 0.0
RAM 124663 124663 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846312 846312 0 0.0
RAM 141251 141251 0 0.0
nxp contact k32w0+release FLASH 585256 585256 0 0.0
RAM 70876 70876 0 0.0
mcxw71+release FLASH 600712 600712 0 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 611196 611196 0 0.0
RAM 70164 70164 0 0.0
k32w1+release FLASH 685680 685680 0 0.0
RAM 48584 48584 0 0.0
lock mcxw71+release FLASH 749536 749536 0 0.0
RAM 67500 67500 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646188 1646188 0 0.0
RAM 211472 211472 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552956 1552956 0 0.0
RAM 208288 208288 0 0.0
light cy8ckit_062s2_43012 FLASH 1438644 1438644 0 0.0
RAM 197040 197040 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467516 1467516 0 0.0
RAM 224704 224704 0 0.0
qpg lighting-app qpg6105+debug FLASH 662188 662188 0 0.0
RAM 105116 105116 0 0.0
lock-app qpg6105+debug FLASH 620304 620304 0 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 459832 459832 0 0.0
RAM 141472 141472 0 0.0
telink bridge-app tl7218x FLASH 665034 665034 0 0.0
RAM 90728 90728 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622078 622078 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 745218 745218 0 0.0
RAM 40396 40396 0 0.0
tl7218x FLASH 753780 753780 0 0.0
RAM 97540 97540 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680850 680850 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709412 709412 0 0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 600592 600592 0 0.0
RAM 138812 138812 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 788820 788820 0 0.0
RAM 96388 96388 0 0.0
tizen all-clusters-app arm unknown 5076 5104 28 0.6
FLASH 1750852 1751016 164 0.0
RAM 93260 93260 0 0.0
chip-tool-ubsan arm unknown 11492 11492 0 0.0
FLASH 18983694 18983694 0 0.0
RAM 8306240 8306240 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2025 •
edited
Loading

PR #37767: Size comparison from ba98125 to da00c2e

Increases above 0.2%:

platform target config section ba98125 da00c2e change % change
esp32 all-clusters-app c3devkit DRAM 97312 98112 800 0.8
m5stack DRAM 116108 116900 792 0.7
tizen all-clusters-app arm unknown 5076 5104 28 0.6
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section ba98125 da00c2e change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1096628 1096628 0 0.0
RAM 94842 94842 0 0.0
bl702 lighting-app bl702+eth FLASH 651606 651606 0 0.0
RAM 33509 33509 0 0.0
bl702+wifi FLASH 828878 828878 0 0.0
RAM 22233 22233 0 0.0
bl706+mfd+rpc+littlefs FLASH 1061274 1061274 0 0.0
RAM 32157 32157 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 892118 892118 0 0.0
RAM 26896 26896 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 975014 975014 0 0.0
RAM 24644 24644 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 815300 815300 0 0.0
RAM 120256 120256 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 824220 824220 0 0.0
RAM 125352 125352 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771080 771080 0 0.0
RAM 113724 113724 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755364 755364 0 0.0
RAM 113932 113932 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538842 538842 0 0.0
RAM 205112 205112 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572998 572998 0 0.0
RAM 205360 205360 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 656429 656429 0 0.0
RAM 75324 75324 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 676289 676289 0 0.0
RAM 77964 77964 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 676289 676289 0 0.0
RAM 77964 77964 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 633213 633213 0 0.0
RAM 70392 70392 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616293 616293 0 0.0
RAM 71532 71532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635929 635929 0 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635929 635929 0 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635789 635789 0 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655513 655513 0 0.0
RAM 77084 77084 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655513 655513 0 0.0
RAM 77084 77084 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 612137 612137 0 0.0
RAM 68628 68628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631997 631997 0 0.0
RAM 71268 71268 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631997 631997 0 0.0
RAM 71268 71268 0 0.0
efr32 lock-app BRD4187C FLASH 939536 939536 0 0.0
RAM 159920 159920 0 0.0
BRD4338a FLASH 732536 732536 0 0.0
RAM 234828 234828 0 0.0
window-app BRD4187C FLASH 1032000 1032000 0 0.0
RAM 128024 128024 0 0.0
esp32 all-clusters-app c3devkit DRAM 97312 98112 800 0.8
FLASH 1582004 1584330 2326 0.1
IRAM 83820 83820 0 0.0
m5stack DRAM 116108 116900 792 0.7
FLASH 1550014 1551754 1740 0.1
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4720 4728 8 0.2
FLASH 2649887 2650031 144 0.0
RAM 111088 111088 0 0.0
all-clusters-app debug unknown 5528 5536 8 0.1
FLASH 5921360 5921536 176 0.0
RAM 513712 513712 0 0.0
all-clusters-minimal-app debug unknown 5424 5432 8 0.1
FLASH 5266394 5266570 176 0.0
RAM 221112 221112 0 0.0
bridge-app debug unknown 5440 5448 8 0.1
FLASH 4625036 4625212 176 0.0
RAM 199816 199816 0 0.0
camera-app debug unknown 5424 5432 8 0.1
FLASH 4671816 4672688 872 0.0
RAM 194592 194752 160 0.1
chip-tool debug unknown 6096 6096 0 0.0
FLASH 13302351 13302351 0 0.0
RAM 603392 603392 0 0.0
chip-tool-ipv6only arm64 unknown 21976 21976 0 0.0
FLASH 11495416 11495416 0 0.0
RAM 656112 656112 0 0.0
fabric-admin debug unknown 5784 5784 0 0.0
FLASH 11567249 11567249 0 0.0
RAM 603176 603176 0 0.0
fabric-bridge-app debug unknown 4688 4696 8 0.2
FLASH 4452254 4452430 176 0.0
RAM 187016 187016 0 0.0
fabric-sync debug unknown 4944 4952 8 0.2
FLASH 5569205 5569381 176 0.0
RAM 470400 470400 0 0.0
lighting-app debug+rpc+ui unknown 6152 6160 8 0.1
FLASH 5515489 5515665 176 0.0
RAM 203952 203952 0 0.0
lock-app debug unknown 5392 5400 8 0.1
FLASH 4688504 4688680 176 0.0
RAM 191144 191144 0 0.0
ota-provider-app debug unknown 4728 4736 8 0.2
FLASH 4310684 4310860 176 0.0
RAM 179832 179832 0 0.0
ota-requestor-app debug unknown 4680 4688 8 0.2
FLASH 4440810 4440986 176 0.0
RAM 184320 184320 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 2949196 2949196 0 0.0
RAM 143672 143672 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4138392 4138536 144 0.0
RAM 229016 229016 0 0.0
tv-app debug unknown 5720 5728 8 0.1
FLASH 5908117 5908261 144 0.0
RAM 593832 593832 0 0.0
tv-casting-app debug unknown 5296 5304 8 0.2
FLASH 11472829 11472973 144 0.0
RAM 718656 718656 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907708 907708 0 0.0
RAM 142323 142323 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901788 901788 0 0.0
RAM 124663 124663 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846312 846312 0 0.0
RAM 141251 141251 0 0.0
nxp contact k32w0+release FLASH 585256 585256 0 0.0
RAM 70876 70876 0 0.0
mcxw71+release FLASH 600712 600712 0 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 611196 611196 0 0.0
RAM 70164 70164 0 0.0
k32w1+release FLASH 685680 685680 0 0.0
RAM 48584 48584 0 0.0
lock mcxw71+release FLASH 749536 749536 0 0.0
RAM 67500 67500 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646188 1646188 0 0.0
RAM 211472 211472 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552956 1552956 0 0.0
RAM 208288 208288 0 0.0
light cy8ckit_062s2_43012 FLASH 1438644 1438644 0 0.0
RAM 197040 197040 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467516 1467516 0 0.0
RAM 224704 224704 0 0.0
qpg lighting-app qpg6105+debug FLASH 662188 662188 0 0.0
RAM 105116 105116 0 0.0
lock-app qpg6105+debug FLASH 620304 620304 0 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 459832 459832 0 0.0
RAM 141472 141472 0 0.0
telink bridge-app tl7218x FLASH 665034 665034 0 0.0
RAM 90728 90728 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622078 622078 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 745218 745218 0 0.0
RAM 40396 40396 0 0.0
tl7218x FLASH 753780 753780 0 0.0
RAM 97540 97540 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680850 680850 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709412 709412 0 0.0
RAM 73400 73400 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 600592 600592 0 0.0
RAM 138812 138812 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 788820 788820 0 0.0
RAM 96388 96388 0 0.0
tizen all-clusters-app arm unknown 5076 5104 28 0.6
FLASH 1750852 1751016 164 0.0
RAM 93260 93260 0 0.0
chip-tool-ubsan arm unknown 11492 11492 0 0.0
FLASH 18983694 18983694 0 0.0
RAM 8306240 8306240 0 0.0

@andy31415
Copy link
Contributor

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 26, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The initial implementation of the WebRTC Provider cluster is a valuable addition. The code demonstrates a clear understanding of the Matter architecture and the requirements for WebRTC integration. Addressing the review comments will further enhance the quality and reliability of this implementation.

Summary of Findings

  • Missing Documentation: The newly added files lack a description of their purpose and functionality. Adding a brief overview at the top of each file would greatly improve readability and understanding.
  • Inconsistent Default Values: In the .zap file, the default values for several attributes are set to null. While this might be acceptable, it's worth investigating whether a more appropriate default value exists for each attribute to ensure proper initialization and behavior.
  • Command Handling: The InvokeCommand function in webrtc-transport-provider-server.cpp could benefit from a more streamlined approach to command handling, potentially using a command map or similar mechanism to reduce code duplication and improve maintainability.

Assessment

This pull request introduces the initial implementation of the WebRTC Provider cluster, which is a significant step towards enabling WebRTC streaming capabilities within the Matter ecosystem. The code is well-structured and includes necessary definitions, attributes, and command handling logic. However, there are a few areas that could benefit from further refinement to ensure robustness and adherence to best practices. Addressing the identified issues would enhance the overall quality and maintainability of the code. Users should have others review and approve this code before merging.

@yufengwangca yufengwangca enabled auto-merge (squash) February 28, 2025 00:26
bzbarsky-apple
bzbarsky-apple requested changes Feb 28, 2025
View reviewed changes
bzbarsky-apple
bzbarsky-apple requested changes Mar 7, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025 •
edited
Loading

PR #37767: Size comparison from d5d2f72 to ee2c929

Full report (7 builds for cc32xx, qpg, stm32, tizen)
platform target config section d5d2f72 ee2c929 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540790 540790 0 0.0
RAM 205128 205128 0 0.0
lock CC3235SF_LAUNCHXL FLASH 574890 574890 0 0.0
RAM 205376 205376 0 0.0
qpg lighting-app qpg6105+debug FLASH 663844 663844 0 0.0
RAM 105156 105156 0 0.0
lock-app qpg6105+debug FLASH 622312 622312 0 0.0
RAM 99768 99768 0 0.0
stm32 light STM32WB5MM-DK FLASH 459920 459920 0 0.0
RAM 141472 141472 0 0.0
tizen all-clusters-app arm unknown 5152 5152 0 0.0
FLASH 1780076 1780076 0 0.0
RAM 94152 94152 0 0.0
chip-tool-ubsan arm unknown 11500 11500 0 0.0
FLASH 18967558 18967558 0 0.0
RAM 8299372 8299372 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025 •
edited
Loading

PR #37767: Size comparison from d5d2f72 to c5af748

Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
platform target config section d5d2f72 c5af748 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1096882 1096882 0 0.0
RAM 94842 94842 0 0.0
bl702 lighting-app bl702+eth FLASH 651856 651856 0 0.0
RAM 33509 33509 0 0.0
bl702+wifi FLASH 829128 829128 0 0.0
RAM 22233 22233 0 0.0
bl706+mfd+rpc+littlefs FLASH 1061524 1061524 0 0.0
RAM 32157 32157 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 892368 892368 0 0.0
RAM 26896 26896 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 975264 975264 0 0.0
RAM 24644 24644 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 817216 817216 0 0.0
RAM 120272 120272 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 826144 826144 0 0.0
RAM 125368 125368 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 773028 773028 0 0.0
RAM 113740 113740 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 757288 757288 0 0.0
RAM 113948 113948 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540790 540790 0 0.0
RAM 205128 205128 0 0.0
lock CC3235SF_LAUNCHXL FLASH 574890 574890 0 0.0
RAM 205376 205376 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 658925 658925 0 0.0
RAM 75412 75412 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 678777 678777 0 0.0
RAM 78052 78052 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 678777 678777 0 0.0
RAM 78052 78052 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 635717 635717 0 0.0
RAM 70480 70480 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619165 619165 0 0.0
RAM 71652 71652 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638801 638801 0 0.0
RAM 74196 74196 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638801 638801 0 0.0
RAM 74196 74196 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 638653 638653 0 0.0
RAM 74660 74660 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 658377 658377 0 0.0
RAM 77204 77204 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 658377 658377 0 0.0
RAM 77204 77204 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614993 614993 0 0.0
RAM 68748 68748 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634853 634853 0 0.0
RAM 71388 71388 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634853 634853 0 0.0
RAM 71388 71388 0 0.0
efr32 lock-app BRD4187C FLASH 939760 939760 0 0.0
RAM 159920 159920 0 0.0
BRD4338a FLASH 733376 733376 0 0.0
RAM 234840 234840 0 0.0
window-app BRD4187C FLASH 1032264 1032264 0 0.0
RAM 128024 128024 0 0.0
esp32 all-clusters-app c3devkit DRAM 98704 98704 0 0.0
FLASH 1593152 1593152 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 117492 117492 0 0.0
FLASH 1559858 1559858 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2653843 2653843 0 0.0
RAM 112304 112304 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5975292 5975292 0 0.0
RAM 515608 515608 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5311902 5311902 0 0.0
RAM 222648 222648 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4625658 4625658 0 0.0
RAM 200984 200984 0 0.0
camera-app debug unknown 5456 5456 0 0.0
FLASH 4675720 4676990 1270 0.0
RAM 195792 195952 160 0.1
camera-controller debug unknown 5776 5776 0 0.0
FLASH 11279431 11279431 0 0.0
RAM 594048 594048 0 0.0
chip-tool debug unknown 6112 6112 0 0.0
FLASH 13292411 13292411 0 0.0
RAM 602944 602944 0 0.0
chip-tool-ipv6only arm64 unknown 21992 21992 0 0.0
FLASH 11488152 11488152 0 0.0
RAM 655536 655536 0 0.0
fabric-admin debug unknown 5800 5800 0 0.0
FLASH 11573059 11573059 0 0.0
RAM 602728 602728 0 0.0
fabric-bridge-app debug unknown 4720 4720 0 0.0
FLASH 4456614 4456614 0 0.0
RAM 188168 188168 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5573573 5573573 0 0.0
RAM 470864 470864 0 0.0
lighting-app debug+rpc+ui unknown 6192 6192 0 0.0
FLASH 5519953 5519953 0 0.0
RAM 205168 205168 0 0.0
lock-app debug unknown 5424 5424 0 0.0
FLASH 4692434 4692434 0 0.0
RAM 192344 192344 0 0.0
ota-provider-app debug unknown 4760 4760 0 0.0
FLASH 4314612 4314612 0 0.0
RAM 181000 181000 0 0.0
ota-requestor-app debug unknown 4712 4712 0 0.0
FLASH 4444964 4444964 0 0.0
RAM 185488 185488 0 0.0
shell debug unknown 4240 4240 0 0.0
FLASH 2952188 2952188 0 0.0
RAM 145424 145424 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4141688 4141688 0 0.0
RAM 229808 229808 0 0.0
tv-app debug unknown 5752 5752 0 0.0
FLASH 5912421 5912421 0 0.0
RAM 594296 594296 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11463069 11463069 0 0.0
RAM 718208 718208 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914784 914784 0 0.0
RAM 142881 142881 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 907992 907992 0 0.0
RAM 125221 125221 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 851604 851604 0 0.0
RAM 141243 141243 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1660300 1660300 0 0.0
RAM 212320 212320 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1564604 1564604 0 0.0
RAM 208536 208536 0 0.0
light cy8ckit_062s2_43012 FLASH 1441340 1441340 0 0.0
RAM 197296 197296 0 0.0
lock cy8ckit_062s2_43012 FLASH 1470212 1470212 0 0.0
RAM 224960 224960 0 0.0
qpg lighting-app qpg6105+debug FLASH 663844 663844 0 0.0
RAM 105156 105156 0 0.0
lock-app qpg6105+debug FLASH 622312 622312 0 0.0
RAM 99768 99768 0 0.0
stm32 light STM32WB5MM-DK FLASH 459920 459920 0 0.0
RAM 141472 141472 0 0.0
telink bridge-app tl7218x FLASH 664564 664564 0 0.0
RAM 90712 90712 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622146 622146 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 760920 760920 0 0.0
RAM 40420 40420 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 754028 754028 0 0.0
RAM 97540 97540 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 681078 681078 0 0.0
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709636 709636 0 0.0
RAM 73400 73400 0 0.0
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 702186 702186 0 0.0
RAM 37664 37664 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 601756 601756 0 0.0
RAM 138640 138640 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 789044 789044 0 0.0
RAM 96388 96388 0 0.0
tizen all-clusters-app arm unknown 5152 5152 0 0.0
FLASH 1780076 1780076 0 0.0
RAM 94152 94152 0 0.0
chip-tool-ubsan arm unknown 11500 11500 0 0.0
FLASH 18967558 18967558 0 0.0
RAM 8299372 8299372 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

PR #37767: Size comparison from d5d2f72 to 79a8969

Increases above 0.2%:

platform target config section d5d2f72 79a89691 change % change
linux air-purifier-app debug FLASH 2653843 2659171 5328 0.2
all-clusters-app debug RAM 515608 516696 1088 0.2
camera-controller debug FLASH 11279431 11345553 66122 0.6
RAM 594048 597312 3264 0.5
chip-tool debug FLASH 13292411 13365611 73200 0.6
RAM 602944 605952 3008 0.5
chip-tool-ipv6only arm64 unknown 21992 22120 128 0.6
FLASH 11488152 11551400 63248 0.6
RAM 655536 658632 3096 0.5
fabric-admin debug FLASH 11573059 11636803 63744 0.6
RAM 602728 605736 3008 0.5
fabric-sync debug RAM 470864 471968 1104 0.2
tv-casting-app debug FLASH 11463069 11538125 75056 0.7
RAM 718208 721744 3536 0.5
tizen chip-tool-ubsan arm unknown 11500 11560 60 0.5
FLASH 18967558 1909284 125288 0.7
RAM 8299372 8355068 55696 0.7
Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
platform target config section d5d2f72 79a89691 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1096882 1098268 1386 0.1
RAM 94842 94866 24 0.0
bl702 lighting-app bl702+eth FLASH 651856 653246 1390 0.2
RAM 33509 33533 24 0.1
bl702+wifi FLASH 829128 830518 1390 0.2
RAM 22233 22257 24 0.1
bl706+mfd+rpc+littlefs FLASH 1061524 1062916 1392 0.1
RAM 32157 32181 24 0.1
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 892368 893758 1390 0.2
RAM 26896 26920 24 0.1
lighting-app bl702l+mfd+littlefs FLASH 975264 976654 1390 0.1
RAM 24644 24668 24 0.1
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 817216 818232 1016 0.1
RAM 120272 120296 24 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 826144 827152 1008 0.1
RAM 125368 125392 24 0.0
pump-app LP_EM_CC1354P10_6 FLASH 773028 774012 984 0.1
RAM 113740 113764 24 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 757288 758288 1000 0.1
RAM 113948 113972 24 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540790 541806 1016 0.2
RAM 205128 205152 24 0.0
lock CC3235SF_LAUNCHXL FLASH 574890 575906 1016 0.2
RAM 205376 205400 24 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 658925 659925 1000 0.2
RAM 75412 75436 24 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 678777 679785 1008 0.1
RAM 78052 78076 24 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 678777 679785 1008 0.1
RAM 78052 78076 24 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 635717 636717 1000 0.2
RAM 70480 70504 24 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619165 620173 1008 0.2
RAM 71652 71676 24 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638801 639809 1008 0.2
RAM 74196 74220 24 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638801 639809 1008 0.2
RAM 74196 74220 24 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 638653 639669 1016 0.2
RAM 74660 74684 24 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 658377 659385 1008 0.2
RAM 77204 77228 24 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 658377 659385 1008 0.2
RAM 77204 77228 24 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614993 616009 1016 0.2
RAM 68748 68772 24 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634853 635869 1016 0.2
RAM 71388 71412 24 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634853 635869 1016 0.2
RAM 71388 71412 24 0.0
efr32 lock-app BRD4187C FLASH 939760 940744 984 0.1
RAM 159920 159944 24 0.0
BRD4338a FLASH 733376 734408 1032 0.1
RAM 234840 234856 16 0.0
window-app BRD4187C FLASH 1032264 1033288 1024 0.1
RAM 128024 128048 24 0.0
esp32 all-clusters-app c3devkit DRAM 98704 98728 24 0.0
FLASH 1593152 1594350 1198 0.1
IRAM 83820 83820 0 0.0
m5stack DRAM 117492 117524 32 0.0
FLASH 1559858 1560958 1100 0.1
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2653843 2659171 5328 0.2
RAM 112304 112304 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5975292 5980720 5428 0.1
RAM 515608 516696 1088 0.2
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5311902 5317164 5262 0.1
RAM 222648 222680 32 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4625658 4630952 5294 0.1
RAM 200984 201000 16 0.0
camera-app debug unknown 5456 5456 0 0.0
FLASH 4675720 4682274 6554 0.1
RAM 195792 195968 176 0.1
camera-controller debug unknown 5776 5776 0 0.0
FLASH 11279431 11345553 66122 0.6
RAM 594048 597312 3264 0.5
chip-tool debug unknown 6112 6112 0 0.0
FLASH 13292411 13365611 73200 0.6
RAM 602944 605952 3008 0.5
chip-tool-ipv6only arm64 unknown 21992 22120 128 0.6
FLASH 11488152 11551400 63248 0.6
RAM 655536 658632 3096 0.5
fabric-admin debug unknown 5800 5800 0 0.0
FLASH 11573059 11636803 63744 0.6
RAM 602728 605736 3008 0.5
fabric-bridge-app debug unknown 4720 4720 0 0.0
FLASH 4456614 4461940 5326 0.1
RAM 188168 188200 32 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5573573 5579029 5456 0.1
RAM 470864 471968 1104 0.2
lighting-app debug+rpc+ui unknown 6192 6192 0 0.0
FLASH 5519953 5525249 5296 0.1
RAM 205168 205168 0 0.0
lock-app debug unknown 5424 5424 0 0.0
FLASH 4692434 4697728 5294 0.1
RAM 192344 192360 16 0.0
ota-provider-app debug unknown 4760 4760 0 0.0
FLASH 4314612 4319874 5262 0.1
RAM 181000 181016 16 0.0
ota-requestor-app debug unknown 4712 4712 0 0.0
FLASH 4444964 4450258 5294 0.1
RAM 185488 185504 16 0.0
shell debug unknown 4240 4240 0 0.0
FLASH 2952188 2957484 5296 0.2
RAM 145424 145456 32 0.0
thermostat-no-ble arm64 unknown 9448 9456 8 0.1
FLASH 4141688 4146808 5120 0.1
RAM 229808 229848 40 0.0
tv-app debug unknown 5752 5752 0 0.0
FLASH 5912421 5917909 5488 0.1
RAM 594296 595400 1104 0.2
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11463069 11538125 75056 0.7
RAM 718208 721744 3536 0.5
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914784 915768 984 0.1
RAM 142881 142881 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 907992 908836 844 0.1
RAM 125221 125221 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 851604 852600 996 0.1
RAM 141243 141243 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1660300 1661316 1016 0.1
RAM 212320 212344 24 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1564604 1565612 1008 0.1
RAM 208536 208560 24 0.0
light cy8ckit_062s2_43012 FLASH 1441340 1442348 1008 0.1
RAM 197296 197320 24 0.0
lock cy8ckit_062s2_43012 FLASH 1470212 1471244 1032 0.1
RAM 224960 224984 24 0.0
qpg lighting-app qpg6105+debug FLASH 663844 664844 1000 0.2
RAM 105156 105180 24 0.0
lock-app qpg6105+debug FLASH 622312 623304 992 0.2
RAM 99768 99792 24 0.0
stm32 light STM32WB5MM-DK FLASH 459920 460920 1000 0.2
RAM 141472 141496 24 0.0
telink bridge-app tl7218x FLASH 664564 665734 1170 0.2
RAM 90712 90712 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622146 623316 1170 0.2
RAM 31488 31488 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 760920 762090 1170 0.2
RAM 40420 40420 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 754028 755198 1170 0.2
RAM 97540 97540 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 681078 682248 1170 0.2
RAM 52192 52192 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709636 710806 1170 0.2
RAM 73400 73400 0 0.0
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 702186 703356 1170 0.2
RAM 37664 37664 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 601756 602926 1170 0.2
RAM 138640 138640 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 789044 790214 1170 0.1
RAM 96388 96388 0 0.0
tizen all-clusters-app arm unknown 5152 5152 0 0.0
FLASH 1780076 1783240 3164 0.2
RAM 94152 94168 16 0.0
chip-tool-ubsan arm unknown 11500 11560 60 0.5
FLASH 18967558 1909284 125288 0.7
RAM 8299372 8355068 55696 0.7

bzbarsky-apple
bzbarsky-apple requested changes Mar 11, 2025
View reviewed changes
yufengwangca and others added 6 commits March 11, 2025 13:03
@yufengwangca @bzbarsky-apple
Update src/app/clusters/webrtc-transport-provider-server/webrtc-trans…
efded59 
…port-provider-server.cpp

Co-authored-by: Boris Zbarsky <[email protected]>
@yufengwangca @bzbarsky-apple
Update src/app/clusters/webrtc-transport-provider-server/webrtc-trans…
aa7532e 
…port-provider-server.cpp

Co-authored-by: Boris Zbarsky <[email protected]>
@yufengwangca @bzbarsky-apple
Update src/app/clusters/webrtc-transport-provider-server/webrtc-trans…
a88ca75 
…port-provider-server.h

Co-authored-by: Boris Zbarsky <[email protected]>
@yufengwangca @bzbarsky-apple
Update src/app/clusters/webrtc-transport-provider-server/webrtc-trans…
f990ac6 
…port-provider-server.h

Co-authored-by: Boris Zbarsky <[email protected]>
@yufengwangca @bzbarsky-apple
Update src/app/clusters/webrtc-transport-provider-server/webrtc-trans…
b4d262d 
…port-provider-server.h

Co-authored-by: Boris Zbarsky <[email protected]>
@yufengwangca
Address review comments
5239c8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@raveendra-karu raveendra-karu raveendra-karu left review comments

@bzbarsky-apple bzbarsky-apple bzbarsky-apple requested changes

@andy31415 andy31415 andy31415 approved these changes

@pidarped pidarped pidarped approved these changes

@saurabhst saurabhst saurabhst approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
app examples review - changed requested scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yufengwangca @andy31415 @pidarped @saurabhst @bzbarsky-apple @raveendra-karu