Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test argument handling: Centralize parsing via env_test.yaml and remove redundant discriminator flag #37340

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Refactor test argument handling: Centralize parsing via env_test.yaml and remove redundant discriminator flag #37340

wants to merge 8 commits into from

Conversation

vatsalghelani-csa
Copy link
Contributor

@vatsalghelani-csa vatsalghelani-csa commented Jan 31, 2025 •
edited
Loading

Work for Issue #31317

PR 25 - Implemented a mechanism to eliminate argument parsing in each file by using env_test.yaml. To ignore default arguments, we added a skip-default-flags list in the test file’s argument block. Initially, we applied this to the discriminator flag and removed it from all test files.

Testing

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jan 31, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  src/python_testing/matter_testing_infrastructure/chip/testing/metadata.py  15% smaller
  src/python_testing/TC_MCORE_FS_1_4.py  1% smaller
  src/python_testing/TCP_Tests.py  0% smaller
  src/python_testing/TC_ACE_1_2.py  0% smaller
  src/python_testing/TC_ACE_1_3.py  0% smaller
  src/python_testing/TC_ACE_1_4.py  0% smaller
  src/python_testing/TC_ACE_1_5.py  0% smaller
  src/python_testing/TC_ACL_2_11.py  0% smaller
  src/python_testing/TC_ACL_2_2.py  0% smaller
  src/python_testing/TC_AccessChecker.py  0% smaller
  src/python_testing/TC_BOOLCFG_2_1.py  0% smaller
  src/python_testing/TC_BOOLCFG_3_1.py  0% smaller
  src/python_testing/TC_BOOLCFG_4_1.py  0% smaller
  src/python_testing/TC_BOOLCFG_4_2.py  0% smaller
  src/python_testing/TC_BOOLCFG_4_3.py  0% smaller
  src/python_testing/TC_BOOLCFG_4_4.py  0% smaller
  src/python_testing/TC_BOOLCFG_5_1.py  0% smaller
  src/python_testing/TC_BOOLCFG_5_2.py  0% smaller
  src/python_testing/TC_BRBINFO_4_1.py  0% smaller
  src/python_testing/TC_CADMIN_1_11.py  0% smaller
  src/python_testing/TC_CADMIN_1_19.py  0% smaller
  src/python_testing/TC_CADMIN_1_22_24.py  0% smaller
  src/python_testing/TC_CADMIN_1_9.py  0% smaller
  src/python_testing/TC_CCTRL_2_1.py  0% smaller
  src/python_testing/TC_CCTRL_2_2.py  0% smaller
  src/python_testing/TC_CCTRL_2_3.py  0% smaller
  src/python_testing/TC_CC_10_1.py  0% smaller
  src/python_testing/TC_CC_2_2.py  0% smaller
  src/python_testing/TC_CGEN_2_4.py  0% smaller
  src/python_testing/TC_CNET_1_4.py  0% smaller
  src/python_testing/TC_DA_1_2.py  0% smaller
  src/python_testing/TC_DA_1_5.py  0% smaller
  src/python_testing/TC_DA_1_7.py  0% smaller
  src/python_testing/TC_DEM_2_1.py  0% smaller
  src/python_testing/TC_DEM_2_10.py  0% smaller
  src/python_testing/TC_DEM_2_2.py  0% smaller
  src/python_testing/TC_DEM_2_3.py  0% smaller
  src/python_testing/TC_DEM_2_4.py  0% smaller
  src/python_testing/TC_DEM_2_5.py  0% smaller
  src/python_testing/TC_DEM_2_6.py  0% smaller
  src/python_testing/TC_DEM_2_7.py  0% smaller
  src/python_testing/TC_DEM_2_8.py  0% smaller
  src/python_testing/TC_DEM_2_9.py  0% smaller
  src/python_testing/TC_DGGEN_2_4.py  0% smaller
  src/python_testing/TC_DGSW_2_1.py  0% smaller
  src/python_testing/TC_DGSW_2_2.py  0% smaller
  src/python_testing/TC_DGSW_2_3.py  0% smaller
  src/python_testing/TC_DGTHREAD_2_2.py  0% smaller
  src/python_testing/TC_DGTHREAD_2_3.py  0% smaller
  src/python_testing/TC_DGTHREAD_2_4.py  0% smaller
  src/python_testing/TC_DGWIFI_2_1.py  0% smaller
  src/python_testing/TC_DGWIFI_2_2.py  0% smaller
  src/python_testing/TC_DGWIFI_2_3.py  0% smaller
  src/python_testing/TC_DRLK_2_12.py  0% smaller
  src/python_testing/TC_DRLK_2_13.py  0% smaller
  src/python_testing/TC_DRLK_2_2.py  0% smaller
  src/python_testing/TC_DRLK_2_3.py  0% smaller
  src/python_testing/TC_DRLK_2_5.py  0% smaller
  src/python_testing/TC_DRLK_2_9.py  0% smaller
  src/python_testing/TC_DeviceBasicComposition.py  0% smaller
  src/python_testing/TC_DeviceConformance.py  0% smaller
  src/python_testing/TC_ECOINFO_2_1.py  0% smaller
  src/python_testing/TC_ECOINFO_2_2.py  0% smaller
  src/python_testing/TC_EEM_2_1.py  0% smaller
  src/python_testing/TC_EEM_2_2.py  0% smaller
  src/python_testing/TC_EEM_2_3.py  0% smaller
  src/python_testing/TC_EEM_2_4.py  0% smaller
  src/python_testing/TC_EEM_2_5.py  0% smaller
  src/python_testing/TC_EEVSE_2_2.py  0% smaller
  src/python_testing/TC_EEVSE_2_3.py  0% smaller
  src/python_testing/TC_EEVSE_2_4.py  0% smaller
  src/python_testing/TC_EEVSE_2_5.py  0% smaller
  src/python_testing/TC_EEVSE_2_6.py  0% smaller
  src/python_testing/TC_EPM_2_1.py  0% smaller
  src/python_testing/TC_EPM_2_2.py  0% smaller
  src/python_testing/TC_EWATERHTR_2_1.py  0% smaller
  src/python_testing/TC_EWATERHTR_2_2.py  0% smaller
  src/python_testing/TC_EWATERHTR_2_3.py  0% smaller
  src/python_testing/TC_FAN_3_1.py  0% smaller
  src/python_testing/TC_FAN_3_2.py  0% smaller
  src/python_testing/TC_FAN_3_3.py  0% smaller
  src/python_testing/TC_FAN_3_4.py  0% smaller
  src/python_testing/TC_FAN_3_5.py  0% smaller
  src/python_testing/TC_ICDM_2_1.py  0% smaller
  src/python_testing/TC_ICDM_3_1.py  0% smaller
  src/python_testing/TC_ICDM_3_2.py  0% smaller
  src/python_testing/TC_ICDM_3_3.py  0% smaller
  src/python_testing/TC_ICDM_3_4.py  0% smaller
  src/python_testing/TC_ICDM_5_1.py  0% smaller
  src/python_testing/TC_ICDManagementCluster.py  0% smaller
  src/python_testing/TC_IDM_1_2.py  0% smaller
  src/python_testing/TC_IDM_1_4.py  0% smaller
  src/python_testing/TC_IDM_4_2.py  0% smaller
  src/python_testing/TC_LVL_2_3.py  0% smaller
  src/python_testing/TC_MCORE_FS_1_1.py  0% smaller
  src/python_testing/TC_MCORE_FS_1_2.py  0% smaller
  src/python_testing/TC_MCORE_FS_1_3.py  0% smaller
  src/python_testing/TC_MCORE_FS_1_5.py  0% smaller
  src/python_testing/TC_MWOCTRL_2_1.py  0% smaller
  src/python_testing/TC_MWOCTRL_2_2.py  0% smaller
  src/python_testing/TC_MWOCTRL_2_4.py  0% smaller
  src/python_testing/TC_MWOM_1_2.py  0% smaller
  src/python_testing/TC_OCC_2_1.py  0% smaller
  src/python_testing/TC_OCC_2_2.py  0% smaller
  src/python_testing/TC_OCC_2_3.py  0% smaller
  src/python_testing/TC_OCC_3_1.py  0% smaller
  src/python_testing/TC_OCC_3_2.py  0% smaller
  src/python_testing/TC_OPCREDS_3_1.py  0% smaller
  src/python_testing/TC_OPCREDS_3_2.py  0% smaller
  src/python_testing/TC_OPCREDS_3_4.py  0% smaller
  src/python_testing/TC_OPCREDS_3_5.py  0% smaller
  src/python_testing/TC_OPSTATE_2_1.py  0% smaller
  src/python_testing/TC_OPSTATE_2_2.py  0% smaller
  src/python_testing/TC_OPSTATE_2_3.py  0% smaller
  src/python_testing/TC_OPSTATE_2_4.py  0% smaller
  src/python_testing/TC_OPSTATE_2_5.py  0% smaller
  src/python_testing/TC_OPSTATE_2_6.py  0% smaller
  src/python_testing/TC_OVENOPSTATE_2_1.py  0% smaller
  src/python_testing/TC_OVENOPSTATE_2_2.py  0% smaller
  src/python_testing/TC_OVENOPSTATE_2_3.py  0% smaller
  src/python_testing/TC_OVENOPSTATE_2_4.py  0% smaller
  src/python_testing/TC_OVENOPSTATE_2_5.py  0% smaller
  src/python_testing/TC_OVENOPSTATE_2_6.py  0% smaller
  src/python_testing/TC_PS_2_3.py  0% smaller
  src/python_testing/TC_PWRTL_2_1.py  0% smaller
  src/python_testing/TC_RR_1_1.py  0% smaller
  src/python_testing/TC_RVCCLEANM_1_2.py  0% smaller
  src/python_testing/TC_RVCCLEANM_2_1.py  0% smaller
  src/python_testing/TC_RVCCLEANM_2_2.py  0% smaller
  src/python_testing/TC_RVCOPSTATE_2_1.py  0% smaller
  src/python_testing/TC_RVCOPSTATE_2_3.py  0% smaller
  src/python_testing/TC_RVCOPSTATE_2_4.py  0% smaller
  src/python_testing/TC_RVCRUNM_1_2.py  0% smaller
  src/python_testing/TC_RVCRUNM_2_1.py  0% smaller
  src/python_testing/TC_RVCRUNM_2_2.py  0% smaller
  src/python_testing/TC_SC_3_6.py  0% smaller
  src/python_testing/TC_SC_4_3.py  0% smaller
  src/python_testing/TC_SEAR_1_2.py  0% smaller
  src/python_testing/TC_SEAR_1_3.py  0% smaller
  src/python_testing/TC_SEAR_1_4.py  0% smaller
  src/python_testing/TC_SEAR_1_5.py  0% smaller
  src/python_testing/TC_SEAR_1_6.py  0% smaller
  src/python_testing/TC_SWTCH.py  0% smaller
  src/python_testing/TC_TCCM_1_2.py  0% smaller
  src/python_testing/TC_TCTL_2_3.py  0% smaller
  src/python_testing/TC_TIMESYNC_2_1.py  0% smaller
  src/python_testing/TC_TIMESYNC_2_10.py  0% smaller
  src/python_testing/TC_TIMESYNC_2_11.py  0% smaller
  src/python_testing/TC_TIMESYNC_2_12.py  0% smaller
  src/python_testing/TC_TIMESYNC_2_13.py  0% smaller
  src/python_testing/TC_TIMESYNC_2_2.py  0% smaller
  src/python_testing/TC_TIMESYNC_2_4.py  0% smaller
  src/python_testing/TC_TIMESYNC_2_5.py  0% smaller
  src/python_testing/TC_TIMESYNC_2_6.py  0% smaller
  src/python_testing/TC_TIMESYNC_2_7.py  0% smaller
  src/python_testing/TC_TIMESYNC_2_8.py  0% smaller
  src/python_testing/TC_TIMESYNC_2_9.py  0% smaller
  src/python_testing/TC_TIMESYNC_3_1.py  0% smaller
  src/python_testing/TC_TSTAT_4_2.py  0% smaller
  src/python_testing/TC_TestAttrAvail.py  0% smaller
  src/python_testing/TC_TestEventTrigger.py  0% smaller
  src/python_testing/TC_VALCC_2_1.py  0% smaller
  src/python_testing/TC_VALCC_3_1.py  0% smaller
  src/python_testing/TC_VALCC_3_2.py  0% smaller
  src/python_testing/TC_VALCC_3_3.py  0% smaller
  src/python_testing/TC_VALCC_3_4.py  0% smaller
  src/python_testing/TC_VALCC_4_1.py  0% smaller
  src/python_testing/TC_VALCC_4_2.py  0% smaller
  src/python_testing/TC_VALCC_4_3.py  0% smaller
  src/python_testing/TC_VALCC_4_4.py  0% smaller
  src/python_testing/TC_VALCC_4_5.py  0% smaller
  src/python_testing/TC_WASHERCTRL_2_1.py  0% smaller
  src/python_testing/TC_WHM_1_2.py  0% smaller
  src/python_testing/TC_WHM_2_1.py  0% smaller
  src/python_testing/TestBatchInvoke.py  0% smaller
  src/python_testing/TestBdxTransfer.py  0% smaller
  src/python_testing/TestGroupTableReports.py  0% smaller
  src/python_testing/TestUnitTestingErrorPath.py  0% smaller
  src/python_testing/hello_test.py  0% smaller
  src/python_testing/matter_testing_infrastructure/env_test.yaml Unsupported file format

@github-actions github-actions bot added the tests label Jan 31, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited
Loading

PR #37340: Size comparison from 58c6789 to b525b80

Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 58c6789 b525b80 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1093546 1093546 0 0.0
RAM 103298 103298 0 0.0
bl702 lighting-app bl702+eth FLASH 650158 650158 0 0.0
RAM 25265 25265 0 0.0
bl702+wifi FLASH 828066 828066 0 0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1056626 1056626 0 0.0
RAM 23861 23861 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888060 888060 0 0.0
RAM 18504 18504 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 971046 971046 0 0.0
RAM 16368 16368 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838000 838000 0 0.0
RAM 123464 123464 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823420 823420 0 0.0
RAM 125344 125344 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770644 770644 0 0.0
RAM 113804 113804 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754888 754888 0 0.0
RAM 114012 114012 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538445 538445 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572309 572309 0 0.0
RAM 205344 205344 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679409 679409 0 0.0
RAM 78532 78532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699261 699261 0 0.0
RAM 81172 81172 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699261 699261 0 0.0
RAM 81172 81172 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656189 656189 0 0.0
RAM 73600 73600 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615793 615793 0 0.0
RAM 71516 71516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635421 635421 0 0.0
RAM 74060 74060 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635421 635421 0 0.0
RAM 74060 74060 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635273 635273 0 0.0
RAM 74524 74524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 654981 654981 0 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 654981 654981 0 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611709 611709 0 0.0
RAM 68612 68612 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631569 631569 0 0.0
RAM 71252 71252 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631569 631569 0 0.0
RAM 71252 71252 0 0.0
efr32 lock-app BRD4187C FLASH 936232 936232 0 0.0
RAM 159904 159904 0 0.0
BRD4338a FLASH 729900 729892 -8 -0.0
RAM 234764 234764 0 0.0
window-app BRD4187C FLASH 1029256 1029248 -8 -0.0
RAM 128040 128040 0 0.0
esp32 all-clusters-app c3devkit DRAM 97296 97296 0 0.0
FLASH 1577036 1577036 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116092 116092 0 0.0
FLASH 1544978 1544978 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4760 4760 0 0.0
FLASH 2708921 2708921 0 0.0
RAM 132816 132816 0 0.0
all-clusters-app debug unknown 5568 5568 0 0.0
FLASH 5974944 5974944 0 0.0
RAM 531632 531632 0 0.0
all-clusters-minimal-app debug unknown 5464 5464 0 0.0
FLASH 5323630 5323630 0 0.0
RAM 242744 242744 0 0.0
bridge-app debug unknown 5480 5480 0 0.0
FLASH 4681818 4681818 0 0.0
RAM 221480 221480 0 0.0
chip-tool debug unknown 6120 6120 0 0.0
FLASH 13096130 13096130 0 0.0
RAM 596770 596770 0 0.0
chip-tool-ipv6only arm64 unknown 21848 21848 0 0.0
FLASH 11162112 11162112 0 0.0
RAM 648496 648496 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11388177 11388177 0 0.0
RAM 596554 596554 0 0.0
fabric-bridge-app debug unknown 4736 4736 0 0.0
FLASH 4506416 4506416 0 0.0
RAM 208664 208664 0 0.0
fabric-sync debug unknown 4976 4976 0 0.0
FLASH 5612789 5612789 0 0.0
RAM 483536 483536 0 0.0
lighting-app debug+rpc+ui unknown 6144 6144 0 0.0
FLASH 5624577 5624577 0 0.0
RAM 231760 231760 0 0.0
lock-app debug unknown 5416 5416 0 0.0
FLASH 4730932 4730932 0 0.0
RAM 207728 207728 0 0.0
ota-provider-app debug unknown 4776 4776 0 0.0
FLASH 4359476 4359476 0 0.0
RAM 201368 201368 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4496948 4496948 0 0.0
RAM 205952 205952 0 0.0
shell debug unknown 4256 4256 0 0.0
FLASH 3004845 3004845 0 0.0
RAM 160504 160504 0 0.0
thermostat-no-ble arm64 unknown 9536 9536 0 0.0
FLASH 4098704 4098704 0 0.0
RAM 246144 246144 0 0.0
tv-app debug unknown 5744 5744 0 0.0
FLASH 5952389 5952389 0 0.0
RAM 606936 606936 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11269741 11269741 0 0.0
RAM 710896 710896 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 906972 906972 0 0.0
RAM 142395 142395 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901532 901532 0 0.0
RAM 124739 124739 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 845696 845696 0 0.0
RAM 141323 141323 0 0.0
nxp contact k32w0+release FLASH 584288 584288 0 0.0
RAM 70860 70860 0 0.0
mcxw71+release FLASH 599632 599632 0 0.0
RAM 63080 63080 0 0.0
light k32w0+release FLASH 610732 610732 0 0.0
RAM 70252 70252 0 0.0
k32w1+release FLASH 685192 685192 0 0.0
RAM 48664 48664 0 0.0
lock mcxw71+release FLASH 748664 748664 0 0.0
RAM 67476 67476 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646372 1646372 0 0.0
RAM 211560 211560 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553148 1553148 0 0.0
RAM 208376 208376 0 0.0
light cy8ckit_062s2_43012 FLASH 1468828 1468828 0 0.0
RAM 200352 200352 0 0.0
lock cy8ckit_062s2_43012 FLASH 1466860 1466860 0 0.0
RAM 224688 224688 0 0.0
qpg lighting-app qpg6105+debug FLASH 661984 661984 0 0.0
RAM 105204 105204 0 0.0
lock-app qpg6105+debug FLASH 619788 619788 0 0.0
RAM 99648 99648 0 0.0
stm32 light STM32WB5MM-DK FLASH 482600 482600 0 0.0
RAM 144672 144672 0 0.0
telink bridge-app tl7218x FLASH 664748 664748 0 0.0
RAM 90812 90812 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621506 621506 0 0.0
RAM 31484 31484 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 770258 770258 0 0.0
RAM 43552 43552 0 0.0
tl7218x FLASH 778790 778790 0 0.0
RAM 98688 98688 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680124 680124 0 0.0
RAM 52176 52176 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 708678 708678 0 0.0
RAM 73384 73384 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625592 625592 0 0.0
RAM 142016 142016 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 812972 812972 0 0.0
RAM 99560 99560 0 0.0
tizen all-clusters-app arm unknown 5116 5116 0 0.0
FLASH 1751892 1751892 0 0.0
RAM 93524 93524 0 0.0
chip-tool-ubsan arm unknown 11408 11408 0 0.0
FLASH 18696094 18696094 0 0.0
RAM 8183744 8183744 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
review - pending tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vatsalghelani-csa @restyled-commits