[1.4 branch] Fix command handling logic for invalid endpoint commands. #37208

andy31415 · 2025-01-27T15:39:24Z

This is the fix for #37184 in the 1.4 branch. Since the logic in 1.4 is a bit different, this was written new rather than cherrypicking #37207

Testing

Manually tested SoftwareDiagnostics::ResetWatermarks on an invalid endpoint and got an error rather than crash.
Added unit-tests:

backported Invoke unit test from 37207
added unit test for GetAcceptedCommandInfo (that is in 1.4 but not present in master anymore)

semanticdiff-com · 2025-01-27T15:39:27Z

Review changes with

src/app/codegen-data-model-provider/CodegenDataModelProvider.cpp

src/app/codegen-data-model-provider/tests/TestCodegenModelViaMocks.cpp

github-actions · 2025-01-27T16:19:20Z

PR #37208: Size comparison from 3e3d4eb to 23ae3bb

Full report (53 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)

platform	target	config	section	`3e3d4eb`	`23ae3bb`	change
bl602	lighting-app	bl602	FLASH	1280574	1280574	0
			RAM	96000	96000	0
		bl602+mfd	FLASH	1308878	1308878	0
			RAM	95656	95656	0
		bl602+rpc	FLASH	1335242	1335242	0
			RAM	103976	103976	0
bl702	lighting-app	bl702	FLASH	944974	944974	0
			RAM	15105	15105	0
		bl702+mfd	FLASH	957684	957684	0
			RAM	14769	14769	0
		bl702+rpc	FLASH	`1051132`	`1051132`	0
			RAM	23661	23661	0
		bl706-eth	FLASH	658106	658106	0
			RAM	24745	24745	0
		bl706-wifi	FLASH	824902	824902	0
			RAM	13965	13965	0
bl702l	lighting-app	bl702l	FLASH	961910	961910	0
			RAM	16804	16804	0
		bl702l+mfd	FLASH	974672	974672	0
			RAM	16468	16468	0
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	829364	829364	0
			RAM	123452	123452	0
	lock-ftd	LP_EM_CC1354P10_6	FLASH	814696	814696	0
			RAM	125332	125332	0
	pump-app	LP_EM_CC1354P10_6	FLASH	761260	761260	0
			RAM	113824	113824	0
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	745496	745496	0
			RAM	114016	114016	0
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	616954	616954	0
			RAM	205908	205908	0
	lock	CC3235SF_LAUNCHXL	FLASH	657058	657058	0
			RAM	206060	206060	0
cyw30739	light	CYW30739B2-P5-EVK-01	unknown	2040	2040	0
			FLASH	678333	678333	0
			RAM	78668	78668	0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0
			FLASH	698185	698185	0
			RAM	81300	81300	0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0
			FLASH	698185	698185	0
			RAM	81300	81300	0
		CYW930739M2EVB-02	unknown	2040	2040	0
			FLASH	655121	655121	0
			RAM	73736	73736	0
	light-switch	CYW30739B2-P5-EVK-01	unknown	2040	2040	0
			FLASH	614677	614677	0
			RAM	71628	71628	0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0
			FLASH	634305	634305	0
			RAM	74180	74180	0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0
			FLASH	634305	634305	0
			RAM	74180	74180	0
	lock	CYW30739B2-P5-EVK-01	unknown	2040	2040	0
			FLASH	633989	633989	0
			RAM	74676	74676	0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0
			FLASH	653705	653705	0
			RAM	77228	77228	0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0
			FLASH	653705	653705	0
			RAM	77228	77228	0
	thermostat	CYW30739B2-P5-EVK-01	unknown	2040	2040	0
			FLASH	609285	609285	0
			RAM	68764	68764	0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0
			FLASH	629145	629145	0
			RAM	71396	71396	0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0
			FLASH	629145	629145	0
			RAM	71396	71396	0
esp32	all-clusters-app	c3devkit	DRAM	94240	94240	0
			FLASH	1538486	1538486	0
			IRAM	82538	82538	0
		m5stack	DRAM	115192	115192	0
			FLASH	1548934	1548934	0
			IRAM	117039	117039	0
linux	chip-tool-ipv6only	arm64	unknown	20672	20672	0
			FLASH	11292944	11293424	480
			RAM	610944	610944	0
	thermostat-no-ble	arm64	unknown	9448	9448	0
			FLASH	4317472	4317952	480
			RAM	242936	242936	0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	914268	914268	0
			RAM	142359	142359	0
		nrf7002dk_nrf5340_cpuapp	FLASH	885072	885072	0
			RAM	140498	140498	0
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	847684	847684	0
			RAM	141253	141253	0
nxp	contact	k32w0+release	FLASH	582024	582024	0
			RAM	70944	70944	0
		k32w1+release	FLASH	596736	596736	0
			RAM	63168	63168	0
		mcxw71+release	FLASH	596496	596496	0
			RAM	63168	63168	0
	light	k32w0+release	FLASH	618612	618612	0
			RAM	70416	70416	0
		k32w1+release	FLASH	682712	682712	0
			RAM	48808	48808	0
		mcxw71+release	FLASH	682728	682728	0
			RAM	48808	48808	0
	lock	k32w1+release	FLASH	705072	705072	0
			RAM	67308	67308	0
		mcxw71+release	FLASH	705096	705096	0
			RAM	67308	67308	0
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1646124	1646124	0
			RAM	211400	211400	0
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	1552196	1552196	0
			RAM	208200	208200	0
	light	cy8ckit_062s2_43012	FLASH	1467652	1467652	0
			RAM	201200	201200	0
	lock	cy8ckit_062s2_43012	FLASH	1464740	1464740	0
			RAM	225560	225560	0
qpg	lighting-app	qpg6105+debug	FLASH	660376	660376	0
			RAM	105396	105396	0
	lock-app	qpg6105+debug	FLASH	618388	618388	0
			RAM	99864	99864	0
stm32	light	STM32WB5MM-DK	FLASH	481664	481664	0
			RAM	144844	144844	0
tizen	all-clusters-app	arm	unknown	4904	4904	0
			FLASH	1725904	1725904	0
			RAM	89076	89076	0
	chip-tool-ubsan	arm	unknown	10424	10424	0
			FLASH	17524234	17524514	280
			RAM	7627864	7627864	0

Co-authored-by: Terence Hampson <[email protected]>

…tedhomeip into fix_bad_endpoint_in_1_4

src/app/codegen-data-model-provider/CodegenDataModelProvider.cpp

github-actions · 2025-01-27T17:23:03Z

PR #37208: Size comparison from 3e3d4eb to b811979

Full report (13 builds for cc32xx, nxp, qpg, stm32, tizen)

platform	target	config	section	`3e3d4eb`	`b811979`	change
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	616954	616954	0
			RAM	205908	205908	0
	lock	CC3235SF_LAUNCHXL	FLASH	657058	657058	0
			RAM	206060	206060	0
nxp	contact	k32w1+release	FLASH	596736	596736	0
			RAM	63168	63168	0
		mcxw71+release	FLASH	596496	596496	0
			RAM	63168	63168	0
	light	k32w1+release	FLASH	682712	682712	0
			RAM	48808	48808	0
		mcxw71+release	FLASH	682728	682728	0
			RAM	48808	48808	0
	lock	k32w1+release	FLASH	705072	705072	0
			RAM	67308	67308	0
		mcxw71+release	FLASH	705096	705096	0
			RAM	67308	67308	0
qpg	lighting-app	qpg6105+debug	FLASH	660376	660376	0
			RAM	105396	105396	0
	lock-app	qpg6105+debug	FLASH	618388	618388	0
			RAM	99864	99864	0
stm32	light	STM32WB5MM-DK	FLASH	481664	481664	0
			RAM	144844	144844	0
tizen	all-clusters-app	arm	unknown	4904	4904	0
			FLASH	1725904	1725904	0
			RAM	89076	89076	0
	chip-tool-ubsan	arm	unknown	10424	10424	0
			FLASH	17524234	17524514	280
			RAM	7627864	7627864	0

… and unit test

github-actions · 2025-01-27T17:41:01Z

PR #37208: Size comparison from 3e3d4eb to 655b21f

Full report (9 builds for cc32xx, nxp, stm32)

platform	target	config	section	`3e3d4eb`	`655b21f`
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	616954	616954
			RAM	205908	205908
	lock	CC3235SF_LAUNCHXL	FLASH	657058	657058
			RAM	206060	206060
nxp	contact	k32w1+release	FLASH	596736	596736
			RAM	63168	63168
		mcxw71+release	FLASH	596496	596496
			RAM	63168	63168
	light	k32w1+release	FLASH	682712	682712
			RAM	48808	48808
		mcxw71+release	FLASH	682728	682728
			RAM	48808	48808
	lock	k32w1+release	FLASH	705072	705072
			RAM	67308	67308
		mcxw71+release	FLASH	705096	705096
			RAM	67308	67308
stm32	light	STM32WB5MM-DK	FLASH	481664	481664
			RAM	144844	144844

github-actions · 2025-01-27T17:58:47Z

PR #37208: Size comparison from 3e3d4eb to 0d2e967

Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)

platform	target	config	section	`3e3d4eb`	`0d2e967`	change	% change
bl602	lighting-app	bl602	FLASH	1280574	1280574	0	0.0
			RAM	96000	96000	0	0.0
		bl602+mfd	FLASH	1308878	1308878	0	0.0
			RAM	95656	95656	0	0.0
		bl602+rpc	FLASH	1335242	1335242	0	0.0
			RAM	103976	103976	0	0.0
bl702	lighting-app	bl702	FLASH	944974	944974	0	0.0
			RAM	15105	15105	0	0.0
		bl702+mfd	FLASH	957684	957684	0	0.0
			RAM	14769	14769	0	0.0
		bl702+rpc	FLASH	`1051132`	`1051132`	0	0.0
			RAM	23661	23661	0	0.0
		bl706-eth	FLASH	658106	658106	0	0.0
			RAM	24745	24745	0	0.0
		bl706-wifi	FLASH	824902	824902	0	0.0
			RAM	13965	13965	0	0.0
bl702l	lighting-app	bl702l	FLASH	961910	961910	0	0.0
			RAM	16804	16804	0	0.0
		bl702l+mfd	FLASH	974672	974672	0	0.0
			RAM	16468	16468	0	0.0
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	FLASH	829364	829364	0	0.0
			RAM	123452	123452	0	0.0
	lock-ftd	LP_EM_CC1354P10_6	FLASH	814696	814696	0	0.0
			RAM	125332	125332	0	0.0
	pump-app	LP_EM_CC1354P10_6	FLASH	761260	761260	0	0.0
			RAM	113824	113824	0	0.0
	pump-controller-app	LP_EM_CC1354P10_6	FLASH	745496	745496	0	0.0
			RAM	114016	114016	0	0.0
cc32xx	air-purifier	CC3235SF_LAUNCHXL	FLASH	616954	616954	0	0.0
			RAM	205908	205908	0	0.0
	lock	CC3235SF_LAUNCHXL	FLASH	657058	657058	0	0.0
			RAM	206060	206060	0	0.0
cyw30739	light	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	678333	678333	0	0.0
			RAM	78668	78668	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	698185	698185	0	0.0
			RAM	81300	81300	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	698185	698185	0	0.0
			RAM	81300	81300	0	0.0
		CYW930739M2EVB-02	unknown	2040	2040	0	0.0
			FLASH	655121	655121	0	0.0
			RAM	73736	73736	0	0.0
	light-switch	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	614677	614677	0	0.0
			RAM	71628	71628	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	634305	634305	0	0.0
			RAM	74180	74180	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	634305	634305	0	0.0
			RAM	74180	74180	0	0.0
	lock	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	633989	633989	0	0.0
			RAM	74676	74676	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	653705	653705	0	0.0
			RAM	77228	77228	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	653705	653705	0	0.0
			RAM	77228	77228	0	0.0
	thermostat	CYW30739B2-P5-EVK-01	unknown	2040	2040	0	0.0
			FLASH	609285	609285	0	0.0
			RAM	68764	68764	0	0.0
		CYW30739B2-P5-EVK-02	unknown	2040	2040	0	0.0
			FLASH	629145	629145	0	0.0
			RAM	71396	71396	0	0.0
		CYW30739B2-P5-EVK-03	unknown	2040	2040	0	0.0
			FLASH	629145	629145	0	0.0
			RAM	71396	71396	0	0.0
efr32	lighting-app	BRD4187C	FLASH	934132	934124	-8	-0.0
			RAM	136244	136244	0	0.0
	lock-app	BRD2605a	FLASH	741288	741264	-24	-0.0
			RAM	232120	232120	0	0.0
		BRD4338a	FLASH	741720	741696	-24	-0.0
			RAM	232004	232004	0	0.0
	window-app	BRD4187C	FLASH	1017536	1017528	-8	-0.0
			RAM	128176	128176	0	0.0
esp32	all-clusters-app	c3devkit	DRAM	94240	94240	0	0.0
			FLASH	1538486	1538486	0	0.0
			IRAM	82538	82538	0	0.0
		m5stack	DRAM	115192	115192	0	0.0
			FLASH	1548934	1548934	0	0.0
			IRAM	117039	117039	0	0.0
linux	air-purifier-app	debug	unknown	4688	4688	0	0.0
			FLASH	2779235	`2779835`	600	0.0
			RAM	129488	129488	0	0.0
	all-clusters-app	debug	unknown	5528	5528	0	0.0
			FLASH	`6083180`	`6083780`	600	0.0
			RAM	510528	510528	0	0.0
	all-clusters-minimal-app	debug	unknown	5424	5424	0	0.0
			FLASH	5416464	5417062	598	0.0
			RAM	241200	241200	0	0.0
	bridge-app	debug	unknown	5408	5408	0	0.0
			FLASH	4749884	4750484	600	0.0
			RAM	218384	218384	0	0.0
	chip-tool	debug	unknown	5960	5960	0	0.0
			FLASH	12654654	12655254	600	0.0
			RAM	560626	560626	0	0.0
	chip-tool-ipv6only	arm64	unknown	20672	20672	0	0.0
			FLASH	11292944	11293408	464	0.0
			RAM	610944	610944	0	0.0
	fabric-admin	debug	unknown	5792	5792	0	0.0
			FLASH	11007307	11007907	600	0.0
			RAM	560058	560058	0	0.0
	fabric-bridge-app	debug	unknown	4632	4632	0	0.0
			FLASH	4572850	4573450	600	0.0
			RAM	205048	205048	0	0.0
	lighting-app	debug+rpc+ui	unknown	6056	6056	0	0.0
			FLASH	5689697	5690289	592	0.0
			RAM	228456	228456	0	0.0
	lock-app	debug	unknown	5344	5344	0	0.0
			FLASH	4799480	4800080	600	0.0
			RAM	204472	204472	0	0.0
	ota-provider-app	debug	unknown	4720	4720	0	0.0
			FLASH	4428868	`4429468`	600	0.0
			RAM	198192	198192	0	0.0
	ota-requestor-app	debug	unknown	4656	4656	0	0.0
			FLASH	4567684	4568284	600	0.0
			RAM	202760	202760	0	0.0
	shell	debug	unknown	4216	4216	0	0.0
			FLASH	`3109277`	3109869	592	0.0
			RAM	159280	159280	0	0.0
	thermostat-no-ble	arm64	unknown	9448	9448	0	0.0
			FLASH	4317472	4317936	464	0.0
			RAM	242936	242936	0	0.0
	tv-app	debug	unknown	5624	5624	0	0.0
			FLASH	`6027317`	6027909	592	0.0
			RAM	584064	584064	0	0.0
	tv-casting-app	debug	unknown	5208	5208	0	0.0
			FLASH	10848765	10849373	608	0.0
			RAM	648912	648912	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	FLASH	914268	914268	0	0.0
			RAM	142359	142359	0	0.0
		nrf7002dk_nrf5340_cpuapp	FLASH	885072	885072	0	0.0
			RAM	140498	140498	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	FLASH	847684	847684	0	0.0
			RAM	141253	141253	0	0.0
nxp	contact	k32w0+release	FLASH	582024	582024	0	0.0
			RAM	70944	70944	0	0.0
		k32w1+release	FLASH	596736	596736	0	0.0
			RAM	63168	63168	0	0.0
		mcxw71+release	FLASH	596496	596496	0	0.0
			RAM	63168	63168	0	0.0
	light	k32w0+release	FLASH	618612	618612	0	0.0
			RAM	70416	70416	0	0.0
		k32w1+release	FLASH	682712	682712	0	0.0
			RAM	48808	48808	0	0.0
		mcxw71+release	FLASH	682728	682728	0	0.0
			RAM	48808	48808	0	0.0
	lock	k32w1+release	FLASH	705072	705072	0	0.0
			RAM	67308	67308	0	0.0
		mcxw71+release	FLASH	705096	705096	0	0.0
			RAM	67308	67308	0	0.0
psoc6	all-clusters	cy8ckit_062s2_43012	FLASH	1646124	1646124	0	0.0
			RAM	211400	211400	0	0.0
	all-clusters-minimal	cy8ckit_062s2_43012	FLASH	1552196	1552196	0	0.0
			RAM	208200	208200	0	0.0
	light	cy8ckit_062s2_43012	FLASH	1467652	1467652	0	0.0
			RAM	201200	201200	0	0.0
	lock	cy8ckit_062s2_43012	FLASH	1464740	1464740	0	0.0
			RAM	225560	225560	0	0.0
qpg	lighting-app	qpg6105+debug	FLASH	660376	660376	0	0.0
			RAM	105396	105396	0	0.0
	lock-app	qpg6105+debug	FLASH	618388	618388	0	0.0
			RAM	99864	99864	0	0.0
stm32	light	STM32WB5MM-DK	FLASH	481664	481664	0	0.0
			RAM	144844	144844	0	0.0
telink	air-quality-sensor-app	tlsr9528a_retention	FLASH	620772	620772	0	0.0
			RAM	50648	50648	0	0.0
	all-clusters-app	tlsr9118bdk40d	FLASH	687976	687976	0	0.0
			RAM	148488	148488	0	0.0
	all-clusters-minimal-app	tlsr9528a	FLASH	780968	780968	0	0.0
			RAM	110440	110440	0	0.0
	bridge-app	tlsr9258a	FLASH	680878	680878	0	0.0
			RAM	91304	91304	0	0.0
	contact-sensor-app	tlsr9528a_retention	FLASH	620536	620536	0	0.0
			RAM	50600	50600	0	0.0
	light-switch-app-ota-shell-factory-data	tlsr9528a	FLASH	708476	708476	0	0.0
			RAM	73940	73940	0	0.0
	lighting-app-ota-factory-data	tlsr9118bdk40d	FLASH	625482	625482	0	0.0
			RAM	144468	144468	0	0.0
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	FLASH	811242	811242	0	0.0
			RAM	99100	99100	0	0.0
	lock-app-dfu	tlsr9528a	FLASH	656442	656442	0	0.0
			RAM	66660	66660	0	0.0
	ota-requestor-app	tlsr9258a	FLASH	696854	696854	0	0.0
			RAM	90896	90896	0	0.0
	pump-app-usb	tlsr9518adk80d	FLASH	634168	634168	0	0.0
			RAM	55476	55476	0	0.0
	pump-controller-app	tlsr9518adk80d	FLASH	611358	611358	0	0.0
			RAM	52720	52720	0	0.0
	shell	tlsr9518adk80d	FLASH	467862	467862	0	0.0
			RAM	68168	68168	0	0.0
	smoke_co_alarm-app	tlsr9528a_retention	FLASH	627696	627696	0	0.0
			RAM	52312	52312	0	0.0
	temperature-measurement-app-mars-ota	tlsr9518adk80d	FLASH	653494	653494	0	0.0
			RAM	56268	56268	0	0.0
	thermostat	tlsr9518adk80d	FLASH	638090	638090	0	0.0
			RAM	53112	53112	0	0.0
	window-covering	tlsr9118bdk40d	FLASH	524236	524236	0	0.0
			RAM	97444	97444	0	0.0
tizen	all-clusters-app	arm	unknown	4904	4904	0	0.0
			FLASH	1725904	1725904	0	0.0
			RAM	89076	89076	0	0.0
	chip-tool-ubsan	arm	unknown	10424	10424	0	0.0
			FLASH	17524234	17524514	280	0.0
			RAM	7627864	7627864	0	0.0

Fix the bad endpoint logic in 1.4

fbd9db3

andy31415 requested review from a team as code owners January 27, 2025 15:39

github-actions bot added the app label Jan 27, 2025

mergify bot added the conflict label Jan 27, 2025

Undo submodule update

01b457c

mergify bot removed the conflict label Jan 27, 2025

andy31415 added 2 commits January 27, 2025 10:54

Back ported unit test

df29f0d

One more unit test

23ae3bb

andy31415 changed the title ~~Fix command handling logic for invalid endpoint commands.~~ [1.4 branch] Fix command handling logic for invalid endpoint commands. Jan 27, 2025

andy31415 removed request for a team January 27, 2025 16:08

tcarmelveilleux approved these changes Jan 27, 2025

View reviewed changes

tehampson reviewed Jan 27, 2025

View reviewed changes

andy31415 and others added 4 commits January 27, 2025 11:59

Update src/app/codegen-data-model-provider/CodegenDataModelProvider.cpp

7832fc3

Co-authored-by: Terence Hampson <[email protected]>

Updated tests based on review comments

8a076a0

Merge branch 'fix_bad_endpoint_in_1_4' of github.com:andy31415/connec…

a21b4e1

…tedhomeip into fix_bad_endpoint_in_1_4

Fix includes

b811979

bzbarsky-apple reviewed Jan 27, 2025

View reviewed changes

src/app/codegen-data-model-provider/CodegenDataModelProvider.cpp Show resolved Hide resolved

andy31415 added 3 commits January 27, 2025 12:23

Address review comment: update listing of accepted/generated commands…

9f9345e

… and unit test

Also fix Next calls

7683163

Update unit tests

655b21f

Fix test

0d2e967

tehampson approved these changes Jan 27, 2025

View reviewed changes

andy31415 merged commit f0a441f into project-chip:v1.4-branch Jan 28, 2025
69 of 70 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[1.4 branch] Fix command handling logic for invalid endpoint commands. #37208

[1.4 branch] Fix command handling logic for invalid endpoint commands. #37208

andy31415 commented Jan 27, 2025 •

edited

Loading

semanticdiff-com bot commented Jan 27, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

[1.4 branch] Fix command handling logic for invalid endpoint commands. #37208

[1.4 branch] Fix command handling logic for invalid endpoint commands. #37208

Conversation

andy31415 commented Jan 27, 2025 • edited Loading

Testing

semanticdiff-com bot commented Jan 27, 2025 • edited Loading

github-actions bot commented Jan 27, 2025 • edited Loading

github-actions bot commented Jan 27, 2025 • edited Loading

github-actions bot commented Jan 27, 2025 • edited Loading

github-actions bot commented Jan 27, 2025 • edited Loading

andy31415 commented Jan 27, 2025 •

edited

Loading

semanticdiff-com bot commented Jan 27, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading