Administrator Commissioning cluster: Use CommandHandlerInterface for handling commands #37078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssioning. Also remove it from the list of auto-generated Ember callbacks.
|
Review changes with Changed Files
|
|
PR #37078: Size comparison from 11a6571 to 5a3f293 Full report (24 builds for cc13x4_26x4, efr32, esp32, linux, nrfconnect, qpg, stm32, telink)
|
|
PR #37078: Size comparison from 11a6571 to c12351c Increases above 0.2%:
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Also change a word in the failing test so it doesn't mislead.
…he one I'm adding.
|
PR #37078: Size comparison from c530e45 to 8772cc7 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…dmin Commissioning cluster's CHI.
|
PR #37078: Size comparison from ff2b0e4 to 1c88175 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37078: Size comparison from 5a825be to 1bff85d Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37078: Size comparison from e80451c to 3ebd686 Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37078: Size comparison from 8be890b to f3793fb Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jan 31, 2025
|
PR #37078: Size comparison from 435583e to 098545d Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36637
Expands the existing attribute interface for the Administrator Commissioning cluster to also handle commands for the cluster. Removes the existing ember command handling for the cluster.
Testing
Manually verified with chip-tool that I could get all-clusters-app to open a basic commissioning window, then commissioned it on another fabric and verified that I could read attributes on each fabric: