Adds lib/support/tests to the ESP32 unit-test target. Makes platform-specific fixes to ParseArgs and EncodeTlvElement. #36847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dress test failures.
|
Review changes with Changed Files
|
github-actions
bot
added
esp32
lib
vscode
github
workflows
support
core
test driver
labels
|
PR #36847: Size comparison from cfdaf79 to c320ab5 Full report (42 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36847: Size comparison from cfdaf79 to 37bd427 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36847: Size comparison from cfdaf79 to da758f2 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36847: Size comparison from cfdaf79 to ebaafcf Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
feasel0
changed the title
|
@feasel0 , can you please post a list of the test logs before and after your changes. If they are many in number, can you please post one log for each type: for e.g.: 1.ParseArgs tests and 2. EnocdeTLV tests in PR description. |
dhrishi
reviewed
Jan 15, 2025
|
|
||
| set -ex | ||
|
|
||
| rm -rf out/esp32-qemu-tests src/test_driver/esp32/managed_components src/test_driver/esp32/sdkconfig src/test_driver/esp32/dependencies.lock |
There was a problem hiding this comment.
Can we get rid of this file by directly calling the cleanup command in the example directory either using the above command or idf.py fullclean?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
src/lib/support/testsinto theesp32-qemu-teststarget.ArgParser::ParseArgs()to work with platforms with a non-POSIXgetopt_long(like ESP32). This was causing failures in some of the test cases inTestCHIPArgParser.cpp.EncodeTlvElement()to work with platforms wheremalloc(0)returns null (like ESP32). This was causing a failure when building zero-length strings, since the null response was being interpreted as "out of memory"..vscode/tasks.jsonto include Build and Run tasks for the ESP32 unit tests.clean.shscript for removing the files generated by the ESP32 unit test build.Notes
How is ESP32's
getopt_longdifferent from the POSIX version?As a result, ParseArgs needs to do a little more work when interpreting the results of
getopt_long. This code is only executed ifCONFIG_NON_POSIX_GETOPT_LONGis defined, which happens automatically insrc/lib/support/BUILD.gnwhenchip_device_platformis "esp32".Testing
Automated testing. CI covers these.