-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish /pt/licoes/extrair-palavras-chave #3446
Conversation
Create Markdown for new PT translation.
Correct `translation_date:`
Olá Eric @ericbrasiln, I’ve staged extrair-palavras-chave for publication. You can read it through in Preview and let me know if you note anything which you'd like to adjust. If you're happy, we can publish this translation next Wednesday. Thank you! |
Update `translation_date:`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @anisa-hawes,
The lesson looks great, and everything is okay overall. I just encountered a small issue with the final code.
When executing the CSV reading on line 502, I received an error related to the file's encoding. To resolve this, I had to include the encoding='latin1'
parameter, like this:
with open('The_Dataset_-_Alumni_Oxonienses-Jas1.csv', encoding='latin1') as csvfile:
I imagine users on Windows and Mac likely haven’t encountered this error, so I believe we can go ahead and publish the lesson.
Best
Thank you, @ericbrasiln. It sounds like it might be useful to add an information box here in case other Linux users experience the same error - I imagine they will benefit from your suggestion of the additional parameter. I've drafted a suggested wording below. What do you think? If you're happy with it, could you translate the alert message into Portuguese?
|
Hi @anisa-hawes Thank you for drafting the suggestion! I’m not entirely sure if this issue is exclusive to Linux users, so it might be better to make the message more general, such as: "Some users may encounter a file encoding error when executing the code to read this CSV file. To resolve this, we suggest including the Below is the translation for the updated message into Portuguese: <div class="alert alert-warning">
Alguns usuários podem encontrar um erro de codificação de arquivo ao executar o código para ler este arquivo CSV. Para resolver isso, sugerimos incluir o parâmetro <code>encoding='latin1'</code>, como no exemplo abaixo:
<code>with open('The_Dataset_-_Alumni_Oxonienses-Jas1.csv', encoding='latin1') as csvfile:</code>
</div> |
Add alert-warning box re: `encoding='latin1'` parameter.
Thank you, @ericbrasiln. I've applied this warning box. The problem links identified in the build are some which I have encountered before #3413 so I will investigate these... |
Add alert-warning box re: `encoding='latin1'` parameter.
Update `translation_date:`
Edit asset links
Fix html code in div box
Thank you, @ericbrasiln! The link issues are all resolved |
Preparing files for publication.
Closes #3445
Checklist
Closes #ISSUENUMBER
to your summary above