Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish /pt/licoes/extrair-palavras-chave #3446

Merged
merged 9 commits into from
Jan 22, 2025

Conversation

anisa-hawes
Copy link
Contributor

@anisa-hawes anisa-hawes commented Jan 8, 2025

Preparing files for publication.

Closes #3445

Checklist

  • Assign yourself in the "Assignees" menu
  • Add the appropriate "Label"
  • If this PR closes an Issue, add the phrase Closes #ISSUENUMBER to your summary above
  • Ensure the status checks pass: if you have difficulty fixing build errors, please contact our Publishing Manager @anisa-hawes
  • Check the Netlify Preview: navigate to netlify/ph-preview/deploy-preview and click 'details' (at right)
  • Assign at least one individual or team to "Reviewers"
    • if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.

Create Markdown for new PT translation.
@anisa-hawes anisa-hawes self-assigned this Jan 8, 2025
@anisa-hawes anisa-hawes changed the title Create extrair-palavras-chave.md Publish /pt/licoes/extrair-palavras-chave Jan 8, 2025
Correct `translation_date:`
@anisa-hawes
Copy link
Contributor Author

anisa-hawes commented Jan 8, 2025

Olá Eric @ericbrasiln,

I’ve staged extrair-palavras-chave for publication. You can read it through in Preview and let me know if you note anything which you'd like to adjust.

If you're happy, we can publish this translation next Wednesday.

Thank you!

Update `translation_date:`
ericbrasiln
ericbrasiln previously approved these changes Jan 14, 2025
Copy link
Member

@ericbrasiln ericbrasiln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anisa-hawes,

The lesson looks great, and everything is okay overall. I just encountered a small issue with the final code.

When executing the CSV reading on line 502, I received an error related to the file's encoding. To resolve this, I had to include the encoding='latin1' parameter, like this:

with open('The_Dataset_-_Alumni_Oxonienses-Jas1.csv', encoding='latin1') as csvfile:

I imagine users on Windows and Mac likely haven’t encountered this error, so I believe we can go ahead and publish the lesson.

Best

@anisa-hawes
Copy link
Contributor Author

Thank you, @ericbrasiln. It sounds like it might be useful to add an information box here in case other Linux users experience the same error - I imagine they will benefit from your suggestion of the additional parameter.

I've drafted a suggested wording below. What do you think? If you're happy with it, could you translate the alert message into Portuguese?

<div class="alert alert-warning">
Linux users may encounter a file encoding error when executing the code to read this CSV file. To resolve this, we suggest including the <code>encoding='latin1'</code> parameter, like this:
<code>with open('The_Dataset_-_Alumni_Oxonienses-Jas1.csv', encoding='latin1') as csvfile:<//code>
</div>

@ericbrasiln
Copy link
Member

Hi @anisa-hawes

Thank you for drafting the suggestion! I’m not entirely sure if this issue is exclusive to Linux users, so it might be better to make the message more general, such as:

"Some users may encounter a file encoding error when executing the code to read this CSV file. To resolve this, we suggest including the encoding='latin1' parameter, like this: with open('The_Dataset_-_Alumni_Oxonienses-Jas1.csv', encoding='latin1') as csvfile:."

Below is the translation for the updated message into Portuguese:

<div class="alert alert-warning">
Alguns usuários podem encontrar um erro de codificação de arquivo ao executar o código para ler este arquivo CSV. Para resolver isso, sugerimos incluir o parâmetro <code>encoding='latin1'</code>, como no exemplo abaixo:  
<code>with open('The_Dataset_-_Alumni_Oxonienses-Jas1.csv', encoding='latin1') as csvfile:</code>
</div>

Add alert-warning box re: `encoding='latin1'` parameter.
@anisa-hawes
Copy link
Contributor Author

Thank you, @ericbrasiln.

I've applied this warning box.

The problem links identified in the build are some which I have encountered before #3413 so I will investigate these...
🔎

anisa-hawes and others added 5 commits January 17, 2025 18:03
Add alert-warning box re: `encoding='latin1'` parameter.
Update `translation_date:`
Fix html code in div box
@anisa-hawes
Copy link
Contributor Author

Thank you, @ericbrasiln!

The link issues are all resolved ☺️

@anisa-hawes anisa-hawes merged commit 039b644 into gh-pages Jan 22, 2025
5 checks passed
@anisa-hawes anisa-hawes deleted the publish-extrair-palavras-chave branch January 22, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preparing to publish a new PT translation: extrair-palavras-chave
3 participants