Ignore cookies if it's been more than 100 minutes #105

programcsharp · Mar 21, 2020 · 44d9408 · 44d9408
1 parent 9ec3a73
commit 44d9408
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/Griddly.Mvc/GriddlyContext.cs b/Griddly.Mvc/GriddlyContext.cs
@@ -29,5 +29,6 @@ public class GriddlyFilterCookieData
     {
         public Dictionary<string, string[]> Values { get; set; }
         public SortField[] SortFields { get; set; }
+        public DateTime? CreatedUtc { get; set; }
     }
 }
diff --git a/Griddly.Mvc/GriddlyCookieFilterValueProvider.cs b/Griddly.Mvc/GriddlyCookieFilterValueProvider.cs
@@ -66,10 +66,16 @@ public override IValueProvider GetValueProvider(ControllerContext controllerCont
                         {
                             var data = JsonConvert.DeserializeObject<GriddlyFilterCookieData>(cookie.Value);
 
-                            context.CookieData = data;
-                            context.IsDefaultSkipped = true;
-
-                            return new GriddlyCookieFilterValueProvider(context);
+                            // chrome/ff don't delete session cookies if they're set to "continue where you left off"
+                            // https://stackoverflow.com/questions/10617954/chrome-doesnt-delete-session-cookies
+                            // only use a cookie if it's new within 100 minutes
+                            if (data.CreatedUtc != null && (DateTime.UtcNow - data.CreatedUtc.Value).TotalMilliseconds < 100)
+                            {
+                                context.CookieData = data;
+                                context.IsDefaultSkipped = true;
+
+                                return new GriddlyCookieFilterValueProvider(context);
+                            }
                         }
                         catch
                         {

diff --git a/Griddly.Mvc/GriddlyParameterAttribute.cs b/Griddly.Mvc/GriddlyParameterAttribute.cs
@@ -87,7 +87,8 @@ public override void OnActionExecuted(ActionExecutedContext filterContext)
 
                         GriddlyFilterCookieData data = new GriddlyFilterCookieData()
                         {
-                            Values = new Dictionary<string, string[]>()
+                            Values = new Dictionary<string, string[]>(),
+                            CreatedUtc = DateTime.UtcNow
                         };
 
                         if (context.SortFields?.Length > 0)