Feat/top bar #34
Merged
Feat/top bar #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfgvieira
force-pushed
the
feat/top-bar
branch
2 times, most recently
from
78b3151 to
962ceeb
Compare
mari1912
reviewed
Jun 28, 2024
dashboard/src/App.tsx
Outdated
| <div className="w-full h-full"> | ||
|
|
||
| <div className="flex flex-row w-full bg-bg"> | ||
|
|
There was a problem hiding this comment.
nit: no need for this new line
| {/* placeholder for search */} | ||
| <Input className="w-2/3" type="text" placeholder="Search" /> | ||
| </div> | ||
| <div>{/* space to put icons on future */}</div> |
There was a problem hiding this comment.
we can remove this for now
|
|
||
| const TopBar = (): JSX.Element => { | ||
| return ( | ||
| <div className="flex fixed top-0 h-20 mx-52 pl-6 pr-12 bg-white w-full "> |
There was a problem hiding this comment.
nit: remove the extra space
dashboard/tailwind.config.js
Outdated
| @@ -32,6 +32,7 @@ module.exports = { | |||
| "accordion-up": "accordion-up 0.2s ease-out", | |||
| }, | |||
| colors: { | |||
| 'bg': '#F4F4F4', | |||
There was a problem hiding this comment.
this color already exists
rfgvieira
force-pushed
the
feat/top-bar
branch
3 times, most recently
from
3552194 to
46cc56e
Compare
added 2 commits
June 28, 2024 17:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Closes #18
Visual reference