Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/eslint config #28

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Chore/eslint config #28

merged 2 commits into from
Jun 26, 2024

Conversation

rfgvieira
Copy link

Description

  • Adds new rules to ESlint
  • Adds new pluging (react, import) to ESlint
  • Fix lint errors on some files

Related Issues

How to test it

  1. Try to make purposeful lint errors
  2. Run pnpm lint on terminal

rfgvieira added 2 commits June 26, 2024 14:55
fix: lint errors
aa63399 
Fix lint errors on src files
Closes #16
chore: ESlint configuration
4404758 
Adds specify rules to ESlint
Adds react and import plugins to ESlint

Part of #16
mari1912
mari1912 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@mari1912 mari1912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I tested and it's working

@rfgvieira rfgvieira merged commit 4404758 into main Jun 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mari1912 mari1912 mari1912 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESLint configuration
2 participants
@rfgvieira @mari1912