total-positions-addition-public-config-api-UI #172
Conversation
|
fixed comments and the |
app/pages/index.vue
Outdated
| <h3 class="text-lg leading-snug text-zinc-600 font-bold mt-8 mb-2">Open Positions</h3> | ||
| <h3 class="text-lg leading-snug text-zinc-600 font-bold mt-8 mb-2"> | ||
| Open Positions | ||
| <span class="text-sm text-zinc-500 before:content-['('] after:content-[')']">>{{ totalPositions }}</span> |
There was a problem hiding this comment.
| <span class="text-sm text-zinc-500 before:content-['('] after:content-[')']">>{{ totalPositions }}</span> | |
| <span class="text-sm text-zinc-500 before:content-['('] after:content-[')']">{{ totalPositions }}</span> |
why extra >?
There was a problem hiding this comment.
Also, See the following img. I want something like that and replace Applicants with Positions that's what I was saying here-> #172 (comment)
|
@karthik8239 Above suggestion need to be completed and please, always create new branch for contributing, for now we will handle. |
Hello shivam,sure I will create a new branch from now I fixed the comment and pushed latest changes.Please review changes and approve my PR. |
app/pages/index.vue
Outdated
| @@ -42,8 +42,8 @@ useSeoMeta({ | |||
| <main class="grow w-full lg:w-2/3 mx-auto mt-20 p-2"> | |||
| <SiteHeader /> | |||
| <h3 class="text-lg leading-snug text-zinc-600 font-bold mt-8 mb-2"> | |||
| Open Positions | |||
| <span class="text-sm text-zinc-500 before:content-['('] after:content-[')']">>{{ totalPositions }}</span> | |||
| Open Applicants | |||
There was a problem hiding this comment.
To add "()" around displaying the number through css instead of text as per @shivam-sharma7 comment.
There was a problem hiding this comment.
I asked for Open Applicants. Why that? we want open postings only.
There was a problem hiding this comment.
Shivam was showing the format in which you have to display number of postings.
server/utils/tasks/seed-cache.ts
Outdated
| const activePostings = await db | ||
| .select({ totalApplicants: jobPostingsTable.totalApplicants }) | ||
| .from(jobPostingsTable) | ||
| .where(eq(jobPostingsTable.isPublished, true)); | ||
|
|
||
| const totalActivePostings = activePostings.length; |
There was a problem hiding this comment.
you need to run count query to get count.
There was a problem hiding this comment.
So the goal is to get total applicants ? not active postings?
There was a problem hiding this comment.
you have to show posting count, not applicants count. Reason we need that from database is because we have future plans in cache management and paging side, so frontend won't be able to show length directly.
|
@amandesai01 thanks for the corrections |
##total-postions-addition-public-config-api-UI
##API update and Ui addition
Changes performed
[Attach screenshots or videos demonstrating the new feature in action.]
Issue Link
#126
Acceptance Criteria
The number of open positions is displayed next to the "Open Positions" header.
Total positions should be taken from cache (general_memoryStorage).
The counter updates automatically when job positions are added, edited, or removed (integrate update in endpoint).
The display should follow the format: "Open Positions (X)", where X is the number of positions.