Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend job postings DB schema #157

Conversation

RishiDesai17
Copy link

Feature Title

Extend the DB schema for Job Postings to accommodate new fields

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Fixes Bug (Fixes an existing functionality which was not working as expected)
  • Documentation change (Changes to Readme.md)

Describe your changes

Added an optional field "validTill" of the type 'date' and a field "isExpired" of the type 'boolean' with default value false

Resolves #136

Checklist

  • I have taken a (git pull origin main --rebase) from main branch and tested it.
  • I have conducted a self-review of my code, and the code contains only changes relevant to this feature, without including modifications to other files.
  • I have commented my code, particularly in complex areas.
  • I have checked for compatibility with other parts of the codebase by manually running the site and doing actions not related to my changes.

@RishiDesai17 RishiDesai17 changed the title Extend job postings db schema Extend job postings DB schema Sep 15, 2024
@RishiDesai17
Copy link
Author

@devshahofficial @shivam-sharma7 Here is the updated PR

@devshahofficial
Copy link
Member

added @amandesai01 as a reviewer

cc @shivam-sharma7

Copy link
Member

@shivam-sharma7 shivam-sharma7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@amandesai01
Copy link
Member

LGTM too, I am just seeing if we need to store timezone info

@shivam-sharma7
Copy link
Member

LGTM too, I am just seeing if we need to store timezone info

might be that people want to see when job has posted on which timezone

@@ -48,6 +48,8 @@ export const jobPostingsTable = pgTable('job_postings', {
}),
isPublished: boolean('is_published').default(false).notNull(),
totalApplicants: integer('total_applicants').default(0).notNull(),
validTill: date('valid_till'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also update schema in ~/shared

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, rebase and resolve merge conflicts

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RishiDesai17 Delete migrations and generate new one, preferably, just create new branch

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RishiDesai17 If you're facing any issue then let me know

@amandesai01
Copy link
Member

@RishiDesai17 you available to do this? We understand if you don't have bandwidth, @shivam-sharma7 can take over.

@amandesai01
Copy link
Member

Assuming @RishiDesai17 not available, will close this PR in some time and un-assign the issue.

@amandesai01 amandesai01 closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend db schema for JobPosting
4 participants