-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend job postings DB schema #157
Extend job postings DB schema #157
Conversation
@devshahofficial @shivam-sharma7 Here is the updated PR |
added @amandesai01 as a reviewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
LGTM too, I am just seeing if we need to store timezone info |
might be that people want to see when job has posted on which timezone |
@@ -48,6 +48,8 @@ export const jobPostingsTable = pgTable('job_postings', { | |||
}), | |||
isPublished: boolean('is_published').default(false).notNull(), | |||
totalApplicants: integer('total_applicants').default(0).notNull(), | |||
validTill: date('valid_till'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also update schema in ~/shared
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, rebase and resolve merge conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RishiDesai17 Delete migrations and generate new one, preferably, just create new branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shivam-sharma7 @amandesai01 sure, will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RishiDesai17 If you're facing any issue then let me know
@RishiDesai17 you available to do this? We understand if you don't have bandwidth, @shivam-sharma7 can take over. |
Assuming @RishiDesai17 not available, will close this PR in some time and un-assign the issue. |
Feature Title
Extend the DB schema for Job Postings to accommodate new fields
Type of Change
Describe your changes
Added an optional field "validTill" of the type 'date' and a field "isExpired" of the type 'boolean' with default value false
Resolves #136
Checklist