Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for arbitrary number of days of back history #32

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

jsnyder
Copy link

@jsnyder jsnyder commented May 9, 2013

This implements an ability to tell the client how many back days of trading history to get at startup. In addition, this should deal with long periods of connection failure by pulling trades sequentially up until the current time.

I mainly wanted to see if you'd be interested in this type of patch, which would be useful for those who want more history in their strategies.

Additional considerations:

  • Takes a while to download trades, probably should have some way of caching them (maybe cpickle).
  • For RAM considerations, one might want to consider garbage collecting candles over a certain age for long-running instances, but this could be a separate patch.

@v3nz3n
Copy link

v3nz3n commented Jul 12, 2013

James, I implemented this patch a few months ago and it has been a brilliant addition to my setup. Basically, I store all tick data and depth messages to a local DB for analysis and mining, so your code and its functionality gave me a basis from which to meaningfully collect, partition and store data. By now my code allows the API to collect historic data from a cache, but the cache building and updates are all happening via this patch. Thanks a lot!

@jsnyder
Copy link
Author

jsnyder commented Jul 12, 2013

Glad to hear it! I was planning on doing something similar, but haven't gotten around to it.

Another thing it might be nice to collect logs of would be the book states going back through history to be used for backtesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants