Add null to Maybe a schemas
#1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Generate a schema for `a` + Generate a schema with the `null` type + Combine both schemas with a `oneOf` to emulate `Maybe a` + Follows behaviour of other `Maybe` instances, e.g., `ToJSON`
rasheedja
requested review from
ChickenProp,
vrom911,
MarceloZabini,
StefanFehrenbach and
TheOddler
rasheedja
removed request for
ChickenProp,
TheOddler,
vrom911,
MarceloZabini and
StefanFehrenbach
|
hold off on merging this, there's a better PR upstream biocad#91 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
anulltypeoneOfto emulateMaybe aMaybeinstances, e.g.,ToJSONUpstream PR: biocad#103