Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add structlog config #1031

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

kasteph
Copy link

@kasteph kasteph commented Mar 28, 2024

Closes #1030

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

PR label(s):

@kasteph kasteph requested a review from a team as a code owner March 28, 2024 17:46
@github-actions github-actions bot added the PR type: documentation 📚 Contains documentation updates label Mar 28, 2024
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Member

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

So you were mentioning in the issue that it wasn't working as intended ? Were you able to fix that ?

I wonder if we should, somehow, test that. Maybe install this in a procrastinate_demo project ? Do you have an opinion ? (I'm not saying you have to do this on the PR (but you may), just asking. Your PR may should get merged at some point, even without that)

docs/howto/production/logging.md Outdated Show resolved Hide resolved

A minimal configuration would look like:

```py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I think we're using python elsewhere, rather than py)

kasteph and others added 2 commits April 1, 2024 11:22
Co-authored-by: Joachim Jablon <[email protected]>
@ewjoachim
Copy link
Member

Hm, I've tried your code and it hasn't worked on the demo so far. I'll try to share a complete traceback later, but has it been working for you ?

@kasteph
Copy link
Author

kasteph commented Apr 8, 2024

Hm, I've tried your code and it hasn't worked on the demo so far. I'll try to share a complete traceback later, but has it been working for you ?

Yes, it has on a bigger project. Did you try the minimal config or the one from the structlog docs?

@ewjoachim
Copy link
Member

ewjoachim commented Apr 9, 2024

I tried the one from your PR, and tried to put it as-is in the sync demo.

@ewjoachim
Copy link
Member

ewjoachim commented Aug 11, 2024

(Hm, I'm sorry, I think this PR went a bit out of sight. We should try and put this back on the table at some point, though I can't make specific commitment. Just wanted to state that I'm sorry we didn't put enough work yet to match the effort you made crafting the PR. But it's not lost.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR type: documentation 📚 Contains documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to configure with structlog?
2 participants