-
Notifications
You must be signed in to change notification settings - Fork 26
Refactor announcements infoCard #89
Refactor announcements infoCard #89
Conversation
I'm not the biggest fan of this existing page in general, and I have a long-term hope of separating concerns into two areas.
Here are some screenshots from exploratory work I've done. Someone can manage announcements and categories from a single view. and then some sort of scrollable newsfeed for end users With all of that being said, I like the changes you are introducing to the existing components. Is it possible to move the edit menu to the top right of the card header? It looks like it's dangling at the end of the card with too much open space around it. Maybe something more similar to this? |
I like your idea @kurtaking to have clear/distinct views between announcements and admin. Is it also scheduled to support different levels of announcements like |
Yeah, it can. I've talked to @drodil about this some, as they had this open PR for that functionality. We just need to get it merged in over here. I also want to create the concept of campaigns that can handle more targeted announcements based on something. For example, I want to be able to say, "Send this announcement to owners of components where type == API and label == something and X team is partOf Y division." I plan to write up more formal issues on all of this in the near future. |
Hello @kurtaking 👋🏽, Nice addition. Yes, I did it manually last time |
Rebase branch |
f6fa329
to
977d9e6
Compare
🦋 Changeset detectedLatest commit: b4e929d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
977d9e6
to
9b95da2
Compare
Hi @kurtaking, I did the changes as requested 👍🏾 |
9b95da2
to
99a5edb
Compare
Hey @gaelgoth, I ran things locally, and the updates look great! Can you do one last thing and look for any screenshots that need to be updated? Looking forward to getting this merged. |
428369e
to
27e02ac
Compare
Signed-off-by: Gaël G <[email protected]>
Signed-off-by: Gaël G <[email protected]>
Signed-off-by: Gaël G <[email protected]>
27e02ac
to
b4e929d
Compare
Hello @kurtaking, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaelgoth looking good, thank you!
Hi @kurtaking, Since you are refactoring the views, I'll would suggest to integrate the excerpt (that I would rename to description or summary which are more common terms) in the detail of the announcement. |
Hey @Nereis, I saw you created an issue for this, correct? Happy to follow up there and get a separate PR going. |
Here is my proposal for #77. The aim is to make something lighter and keep it on line with this infocard: https://github.com/procore-oss/backstage-plugin-announcements/blob/main/docs/images/announcements_card.png.
Here's what it looks like:
Depending on your feedback @kurtaking , I'll do that next: