Skip to content
This repository has been archived by the owner on Dec 27, 2024. It is now read-only.

fix: AnnouncementCollatorApi iterable error #86

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

gaelgoth
Copy link
Contributor

This time I tested it on my instance. Collector successfully fetched announcements.

[1] 2023-10-27T09:22:37.744Z search info Collating documents for announcements via AnnouncementCollatorFactory type=plugin documentType=announcements
[1] 2023-10-27T09:22:37.745Z search info indexing announcements type=plugin
[1] 2023-10-27T09:22:37.767Z backstage info ::ffff:127.0.0.1 - - [27/Oct/2023:09:22:37 +0000] "GET /api/announcements/announcements HTTP/1.1" 200 205 "-" "node-fetch/1.0 (+https://github.com/bitinn/node-fetch)" type=incomingRequest
[1] 2023-10-27T09:22:37.770Z search debug got 1 announcements type=plugin
[1] 2023-10-27T09:22:37.770Z search debug mapping announcement 8541a1dc-2725-4c79-a367-dc91bd43282b to indexable document type=plugin
[1] 2023-10-27T09:22:37.779Z search info Collating documents for announcements succeeded type=plugin documentType=announcements
[1] 2023-10-27T09:22:37.782Z backstage debug task: search_index_announcements will next occur around 2023-10-27T11:32:37.780+02:00 type=taskManager task=search_index_announcements

@gaelgoth gaelgoth requested review from kurtaking and a team as code owners October 27, 2023 09:53
@gaelgoth gaelgoth force-pushed the fix/collector-iterable branch from 5233999 to 7407f25 Compare October 27, 2023 09:53
@kurtaking kurtaking self-assigned this Oct 27, 2023
@kurtaking kurtaking added the bug An issue with the system label Oct 27, 2023
Copy link
Member

@kurtaking kurtaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cross-referenced as you did and things look good 👍🏼 Thank you for your contribution!

@kurtaking kurtaking merged commit c81ae81 into procore-oss:main Oct 27, 2023
@gaelgoth gaelgoth deleted the fix/collector-iterable branch October 30, 2023 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug An issue with the system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants