This repository has been archived by the owner on Dec 27, 2024. It is now read-only.
fix: set proper metadata action when an announcement is deleted #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4e9be51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mycodeself
force-pushed
the
fix/wrong-event-on-announcement-delete
branch
from
1a8c1e8 to
c68a179
Compare
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: mycodeself <[email protected]>
Signed-off-by: mycodeself <[email protected]>
mycodeself
force-pushed
the
fix/wrong-event-on-announcement-delete
branch
from
c68a179 to
d227a3f
Compare
fnicolelli-ls
approved these changes
Dec 3, 2024
Signed-off-by: mycodeself <[email protected]>
…ub.com/mycodeself/backstage-plugin-announcements into fix/wrong-event-on-announcement-delete
kurtaking
approved these changes
Dec 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary 📰
Set proper
metadata.actionfor the event triggered when an announcement is deleted.Fixes #516
Details 📚
Is just a small change, instead sending the
EVENTS_ACTION_DELETE_CATEGORYwhen an announcement is deleted now it sends the proper oneEVENTS_ACTION_DELETE_ANNOUNCEMENTChecklist ✅
Testing Notes 🔬