Bug Fix: Creating a category with a different slug and title will prevent the announcement from being created #351 #360
Conversation
lavanya-sainik-ericsson
requested review from
kurtaking and
a team
as code owners
🦋 Changeset detectedLatest commit: 544d4b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
We noticed the same issue on our side. Thanks for the fix 👍 |
|
The behavior in the category field on the form is not what I'd expect it to be. It seems that when selecting an existing category, it populates the slug value and tries to create a new entry. Is that what you are experiencing? Sorry it's taken so long. I'm on limited capacity until the second week of July, but want to help get a fix merged this week. |
…vent the announcement from being created procore-oss#351 Signed-off-by: elavsai [email protected]
…vent the announcement from being created Signed-off-by: elavsai [email protected]
lavanya-sainik-ericsson
force-pushed
the
announcement_category_improvement
branch
from
a151169 to
c578887
Compare
|
Hey kurtaking, Thanks for your comment. Have updated the PR with the changes. Request your review based on your availability and let me know if any further comments :) |
|
Hey kurtaking, Just a gentle reminder :) Have resolved the given comments. Thanks |
Hey @lavanya-sainik-ericsson, I apologize for being so slow to help but I am back and will dedicate some time this afternoon. |
|
I have also opened this issue, which would help with situations like this in the future. |
|
The lock file is out of sync here. I opened a separate branch (PR) to verify. I'll first check in around 9 am MST tomorrow. Get the lock file updated and we can merge. |
|
👋🏼 checking in a bit earlier - I'll be on the lookout for a response in the next few hours. Otherwise, I'll help by merging the PR I created with the updated lock file. |
Signed-off-by: Kurt King <[email protected]>
|
Learned to push directly to your PR by following this gist. I want to make sure you get credit for the contribution PR. Thank you, @lavanya-sainik-ericsson , for your patience and contribution 😄 |
|
Hey kurtaking, Thanks a lot for reviewing and merging this PR :) |
Signed-off-by: elavsai [email protected]
Checklist: