Skip to content
This repository has been archived by the owner on Dec 27, 2024. It is now read-only.

[DONE] Migrating announcements plugins to @backstage-community/plugins repository #373

Closed
6 tasks done
kurtaking opened this issue Jul 8, 2024 · 13 comments · Fixed by #541
Closed
6 tasks done

[DONE] Migrating announcements plugins to @backstage-community/plugins repository #373

kurtaking opened this issue Jul 8, 2024 · 13 comments · Fixed by #541
Assignees
Labels
help wanted Anyone is welcome to open a pull request to fix this issue question Further information is requested

Comments

@kurtaking
Copy link
Contributor

kurtaking commented Jul 8, 2024

Summary

The announcement plugins should be migrated to backstage/community-plugins. When we first took these over, that repository didn't exist, and the main repo no longer allowed new plugins. If it had, I would have migrated them there and volunteered to be a maintainer. The biggest benefit from migrating is the chance for additional maintainers passionate about the plugins to have more ownership.

My rough draft plan would be to

  1. Update plugins to the latest version of backstage
  2. Resolve any outstanding Issues
  3. Migrate plugins
  4. Redirect feature requests to backstage/community-plugins

Thoughts and comments?


Update - December 6, 2024

The workspace has been created, and the search module has been migrated. Plugins will not be marked as deprecated in the procore-oss org until ALL plugins are migrated.

  • PR @procore-oss/backstage-plugin-announcements-backend
  • PR @procore-oss/backstage-plugin-announcements-common
  • PR @procore-oss/backstage-plugin-announcements-node
  • PR @procore-oss/backstage-plugin-announcements
  • PR @procore-oss/backstage-plugin-search-backend-module-announcements
  • PR @procore-oss/backstage-plugin-announcements-react

Update - December 17, 2024

We have decided we will not create a changeset until all plugins are migrated.

Update - December 27, 2024

@kurtaking kurtaking added the question Further information is requested label Jul 8, 2024
@kurtaking kurtaking self-assigned this Jul 8, 2024
@kurtaking
Copy link
Contributor Author

@gaelgoth wanted to make sure you saw this as you come to mind when I think of additional maintainers.

@gaelgoth
Copy link
Contributor

gaelgoth commented Jul 9, 2024

It makes sense to move the community repository. I would be happy to help and contribute as a maintainer

@kurtaking
Copy link
Contributor Author

kurtaking commented Aug 19, 2024

I've started this process here - backstage/community-plugins#880

@kurtaking kurtaking pinned this issue Aug 19, 2024
@awanlin
Copy link

awanlin commented Aug 23, 2024

Hi @kurtaking, I saw that the PR you submitted is closed, is the plan to move this still?

@kurtaking
Copy link
Contributor Author

Hi @kurtaking, I saw that the PR you submitted is closed, is the plan to move this still?

hey @awanlin, yes, that is the plan, but I have struggled to find the time to do so.

@awanlin
Copy link

awanlin commented Aug 25, 2024

Thanks for the update @kurtaking, just wasn't sure if plans had changed once I saw the PR was closed. 👍

@kurtaking
Copy link
Contributor Author

Thanks for the update @kurtaking, just wasn't sure if plans had changed once I saw the PR was closed. 👍

First-time father with a 3-month-old is taking up all of my free time. 😄 On the flip side, that's also why I need to get it done. So others aren't affected by my absence.

@kurtaking
Copy link
Contributor Author

Here is the new PR for migration.

@kurtaking kurtaking changed the title RFC: Migrating to backstage/community-plugins [IN-PROGRESS]: Migrating to backstage/community-plugins Aug 30, 2024
@kurtaking kurtaking changed the title [IN-PROGRESS]: Migrating to backstage/community-plugins [IN-PROGRESS]: Migrating announcements plugins to @backstage-community/plugins repository Aug 30, 2024
@kurtaking kurtaking unpinned this issue Oct 1, 2024
@kurtaking kurtaking changed the title [IN-PROGRESS]: Migrating announcements plugins to @backstage-community/plugins repository [ON HOLD]: Migrating announcements plugins to @backstage-community/plugins repository Oct 5, 2024
@kurtaking kurtaking pinned this issue Oct 5, 2024
@matdtr
Copy link

matdtr commented Nov 17, 2024

Hi,

I saw backstage/community-plugins#1637, it went stale due to the migration being still on hold? Or PR should be reopened by backstage maintainers?
Would like to add this plugin to my instance.

thanks

@awanlin
Copy link

awanlin commented Nov 18, 2024

I'm happy to reopen it, odd that it never got assigned to anyone when it was created. The challenge is two fold:

  1. On our side - Community Plugin Maintainers - this is a massive PR of 150 files to review, as there won't be proper ownership for it, meaning it wall fall to use to review all changes, we need to make sure everything follows the proper conventions.
  2. On the Procore side we need someone to help follow up on comments.

@kurtaking kurtaking added the help wanted Anyone is welcome to open a pull request to fix this issue label Nov 25, 2024
@kurtaking
Copy link
Contributor Author

kurtaking commented Nov 25, 2024

I'm happy to reopen it, odd that it never got assigned to anyone when it was created. The challenge is two fold:

  1. On our side - Community Plugin Maintainers - this is a massive PR of 150 files to review, as there won't be proper ownership for it, meaning it wall fall to use to review all changes, we need to make sure everything follows the proper conventions.

  2. On the Procore side we need someone to help follow up on comments.

I continue to struggle to find time to take care of this. I agree the PR gets too large too quickly, and twice I have given up due to being overwhelmed.

I was thinking maybe we move one plugin at a time to narrow the scope of each PR?


I want it to live in the community repo where I'd like to continue to be a maintainer with hopefully some additional support 🙏🏼 .
Our direction internally hasn't fully utilized announcements like we originally intended, and it's hard to give the plugins the attention they need when we aren't actively adding feature enhancements.

@kurtaking kurtaking changed the title [ON HOLD]: Migrating announcements plugins to @backstage-community/plugins repository Migrating announcements plugins to @backstage-community/plugins repository Dec 6, 2024
@kurtaking
Copy link
Contributor Author

@awanlin - I have a few PRs ready for review in community-plugins. 🎉

@kurtaking
Copy link
Contributor Author

#541 deprecates the plugins under the @procore-oss namespace and is the final PR as part of the migration effort.

@kurtaking kurtaking changed the title Migrating announcements plugins to @backstage-community/plugins repository [COMPLETED 12/27/24] Migrating announcements plugins to @backstage-community/plugins repository Dec 27, 2024
@kurtaking kurtaking changed the title [COMPLETED 12/27/24] Migrating announcements plugins to @backstage-community/plugins repository [DONE] Migrating announcements plugins to @backstage-community/plugins repository Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Anyone is welcome to open a pull request to fix this issue question Further information is requested
Projects
None yet
4 participants