Skip to content

Fix: Update arc() documentation to reflect angleMode() setting #7562 #7661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rajanarahul93
Copy link

Resolves #7562

Changes:

  • Updated the documentation for the arc() function to clarify that it respects angleMode().
  • Reviewed and ensured consistency in related math function documentation (e.g., sin(), cos(), tan()).

Screenshots of the change:

N/A (as this is a documentation update).

PR Checklist:

  • npm run lint passes
  • Inline reference is included/updated
  • Unit tests are included/updated

@davepagurek

Copy link

welcome bot commented Mar 24, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

@ksen0
Copy link
Member

ksen0 commented Mar 25, 2025

Hi @rajanarahul93 , thanks for looking into this! However, it looks like the issue you were working on has already been assigned to someone else, and also has a PR out awaiting review. Because of this duplicated effort, I will unfortunately close the PR.

In the future, please keep in mind that in our contributor guidelines we ask that contributors do not jump in with PRs unless there is agreement on the issue on what should be done and who should do it.

@ksen0 ksen0 closed this Mar 25, 2025
@rajanarahul93
Copy link
Author

Hey @ksen0 ,

Thanks for the heads-up! I completely understand, and I’ll be more mindful of issue assignments and discussions before opening a PR next time. Appreciate the feedback, and I’ll make sure to follow the contributor guidelines more closely moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arc() function docs say it only uses radians, but it actually listens to angleMode()
2 participants