Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo: Add a demo #118

Merged
merged 3 commits into from
Jul 17, 2017
Merged

demo: Add a demo #118

merged 3 commits into from
Jul 17, 2017

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Jun 13, 2017

ref https://www.openprocessing.org/sketch/377464

Just for fun

Delay until #97
Signed-off-by: Ce Gao [email protected]

Signed-off-by: Ce Gao <[email protected]>
@jeremydouglass
Copy link
Member

jeremydouglass commented Jun 13, 2017

Tested this, and it ran fine. Nice adaptation of the reference sketch -- your original wobbly ellipse phase is particularly fun. :)

Remind me: why is:

radians = RLangPApplet$radians

...something that must be defined in src/rprocessing/r/core.R -- why can it not simply be added to the top of FiguresTransformation.rpde as a local definition? I know that it does not work, but what is the explanation?

@gaocegege
Copy link
Member Author

I think it is caused by our policy to eval the code, but I am not sure the specific reason. 🤔

@jeremydouglass
Copy link
Member

Could this be resolved now that #97 has a functional workaround?

@gaocegege
Copy link
Member Author

Yeah, I will refactor the code and merge it.

@gaocegege gaocegege merged commit 39919eb into master Jul 17, 2017
@gaocegege gaocegege deleted the example/demo/figure branch July 17, 2017 02:50
@gaocegege gaocegege added this to the Evaluation 2 milestone Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants