Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump the typescript from 5.4.5 to 5.5.4 #3124

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 30, 2024

Updates typescript from 5.4.5 to 5.5.4

Release notes

Sourced from typescript's releases.

TypeScript 5.5.4

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.5.3

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.5

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.5 RC

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

... (truncated)

Commits
  • c8a7d58 Bump version to 5.5.4 and LKG
  • c0ded04 🤖 Pick PR #58771 (Allow references to the global Symb...) into release-5.5 (#...
  • 5ba41e2 🤖 Pick PR #59208 (Write non-missing undefined on mapp...) into release-5.5 (#...
  • b075332 🤖 Pick PR #59337 (Allow declarationMap to be emitted ...) into release-5.5 (#...
  • 9dd6f91 Cherry-pick "Stop using latest Node in CI" to release-5.5 (#59348)
  • bf0ddaf 🤖 Pick PR #59070 (Delay the calculation of common sou...) into release-5.5 (#...
  • a44e2d9 🤖 Pick PR #59160 (Fixed crash on authored import type...) into release-5.5 (#...
  • f35206d 🤖 Pick PR #59325 (Don't skip markLinkedReferences on ...) into release-5.5 (#...
  • 1109550 Fix baselines on release-5.5 (#59330)
  • 8794318 🤖 Pick PR #59215 (Fix codefix crash on circular alias...) into release-5.5 (#...
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency (dev or runtime) javascript Pull requests that update Javascript code skip-changelog Do not include in Changelog and Release Notes labels Jul 30, 2024
@dependabot dependabot bot requested review from a team, csouchet, tbouffard and oanesini and removed request for a team July 30, 2024 12:29
@csouchet csouchet marked this pull request as draft July 30, 2024 14:02
@csouchet
Copy link
Member

To be reopened later to avoid to block other dependabot PRs

@csouchet csouchet closed this Jul 30, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 30, 2024

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

To ignore these dependencies, configure ignore rules in dependabot.yml

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/typescript-bdaf0f2ef2 branch July 30, 2024 15:06
@csouchet csouchet restored the dependabot/npm_and_yarn/typescript-bdaf0f2ef2 branch July 31, 2024 08:01
@csouchet csouchet reopened this Jul 31, 2024
@csouchet
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/typescript-bdaf0f2ef2 branch from 1343e8d to 4edfb3c Compare July 31, 2024 08:03
dependabot bot and others added 3 commits July 31, 2024 10:35
Bumps the typescript group with 2 updates: [typedoc](https://github.com/TypeStrong/TypeDoc) and [typescript](https://github.com/Microsoft/TypeScript).


Updates `typedoc` from 0.25.13 to 0.26.5
- [Release notes](https://github.com/TypeStrong/TypeDoc/releases)
- [Changelog](https://github.com/TypeStrong/typedoc/blob/master/CHANGELOG.md)
- [Commits](TypeStrong/typedoc@v0.25.13...v0.26.5)

Updates `typescript` from 5.4.5 to 5.5.4
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml)
- [Commits](microsoft/TypeScript@v5.4.5...v5.5.4)

---
updated-dependencies:
- dependency-name: typedoc
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: typescript
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: typescript
...

Signed-off-by: dependabot[bot] <[email protected]>
@csouchet csouchet force-pushed the dependabot/npm_and_yarn/typescript-bdaf0f2ef2 branch from 4edfb3c to 80509e6 Compare July 31, 2024 08:36
@csouchet
Copy link
Member

Bug introduced by microsoft/TypeScript#58026.

> [email protected] build
> tsc --noEmit
node_modules/@types/node/globals.d.ts:72:13 - error TS2403: Subsequent variable declarations must have the same type.  Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; abort(reason?: any): AbortSignal; any(signals: AbortSignal[]): AbortSignal; timeout(milliseconds: number): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; abort(reason?: any): AbortSignal; timeout(milliseconds: number): AbortSignal; }'.
72 declare var AbortSignal: {
              ~~~~~~~~~~~
 node_modules/typescript/lib/lib.dom.d.ts:2360:13
   2360 declare var AbortSignal: {
                    ~~~~~~~~~~~
   'AbortSignal' was also declared here.

Found 1 error in node_modules/@types/node/globals.d.ts:72

They declared a var named AbortSignal in typescript, but it already exists in node. So, there is a conflict.

@tbouffard
Copy link
Member

ℹ️ in the past, we already had an issue with the AbortSignal type coming from @types/node.
At that time, we introduce an overrides attribute in package.json to force the version of @types/node:

The version we use for @types/node is very old (v16) and doesn't match the version of Node (v20) we are using to build.
I am going to test to bump this version to see if this fixes the problem.

Copy link

github-actions bot commented Aug 12, 2024

🎊 PR Preview 5ca7a36 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-3124.surge.sh

🕐 Build time: 0.011s

🤖 By surge-preview

Copy link

github-actions bot commented Aug 12, 2024

🎊 PR Preview 5ca7a36 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-3124.surge.sh

🕐 Build time: 0.011s

🤖 By surge-preview

@tbouffard
Copy link
Member

tbouffard commented Aug 12, 2024

🎉 Removing the @types/node overrides fix the AbortSignal problem

❌ But now, we see a new problem. The types in the npm package are missing a reference to the mxGraph types provided by typed-mxgraph.
[IN PROGRESS]
The following reference declaration is missing in the dist/bpmn-visualization.d.ts file included in the npm package.
It is also missing in the build/xxxxxxxxxx/BpmnGraph.d.ts file used to generate the type file included in the npm package.

/// <reference types="@typed-mxgraph/typed-mxgraph" />

Example of error taken from https://github.com/process-analytics/bpmn-visualization-js/actions/runs/10349520383/job/28647774207#step:10:1

Error: ../../dist/bpmn-visualization.d.ts(17,41): error TS7016: Could not find a declaration file for module 'mxgraph'. '/home/runner/work/bpmn-visualization-js/bpmn-visualization-js/node_modules/mxgraph/javascript/dist/build.js' implicitly has an 'any' type.
Try `npm install @types/mxgraph` if it exists or add a new declaration (.d.ts) file containing `declare module 'mxgraph';`
Error: ../../dist/bpmn-visualization.d.ts(18,37): error TS7016: Could not find a declaration file for module 'mxgraph'. '/home/runner/work/bpmn-visualization-js/bpmn-visualization-js/node_modules/mxgraph/javascript/dist/build.js' implicitly has an 'any' type.
Try `npm install @types/mxgraph` if it exists or add a new declaration (.d.ts) file containing `declare module 'mxgraph';`
Error: ../../dist/bpmn-visualization.d.ts(19,37): error TS7016: Could not find a declaration file for module 'mxgraph'. '/home/runner/work/bpmn-visualization-js/bpmn-visualization-js/node_modules/mxgraph/javascript/dist/build.js' implicitly has an 'any' type.
Try `npm install @types/mxgraph` if it exists or add a new declaration (.d.ts) file containing `declare module 'mxgraph';`
Error: Process completed with exit code 2.

@tbouffard tbouffard changed the title chore(deps-dev): bump the typescript group with 2 updates chore(deps-dev): bump the typescript from 5.4.5 to 5.5.4 Aug 26, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 2, 2024

Looks like these dependencies are updatable in another way, so this is no longer needed.

@dependabot dependabot bot closed this Sep 2, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/typescript-bdaf0f2ef2 branch September 2, 2024 00:04
@tbouffard tbouffard restored the dependabot/npm_and_yarn/typescript-bdaf0f2ef2 branch September 2, 2024 07:27
@tbouffard
Copy link
Member

Reopening PR, this is where we are working to make the build pass.

@tbouffard
Copy link
Member

tbouffard commented Sep 2, 2024

Requesting dependabot to ignore typescript updates until we find a solution to fix the problem.

@tbouffard
Copy link
Member

@dependabot ignore typescript

Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 2, 2024

OK, I won't notify you about typescript again, unless you unignore it.

Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 2, 2024

Looks like these dependencies are no longer updatable, so this is no longer needed.

@dependabot dependabot bot closed this Sep 2, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/typescript-bdaf0f2ef2 branch September 2, 2024 07:49
@tbouffard tbouffard restored the dependabot/npm_and_yarn/typescript-bdaf0f2ef2 branch September 2, 2024 07:52
@tbouffard tbouffard reopened this Sep 2, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 9, 2024

Looks like these dependencies are updatable in another way, so this is no longer needed.

@dependabot dependabot bot closed this Sep 9, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/typescript-bdaf0f2ef2 branch September 9, 2024 00:03
@tbouffard tbouffard restored the dependabot/npm_and_yarn/typescript-bdaf0f2ef2 branch September 9, 2024 05:47
@tbouffard tbouffard reopened this Sep 9, 2024
Copy link

sonarcloud bot commented Sep 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency (dev or runtime) javascript Pull requests that update Javascript code skip-changelog Do not include in Changelog and Release Notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants