Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(UI): Clarify how items can be added to a view #542

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(UI): Clarify how items can be added to a view #542

wants to merge 3 commits into from
+174 −61

Conversation

rouk1
Copy link
Contributor

@rouk1 rouk1 commented Oct 18, 2024

This PR

  • disable double click action
  • add optional actions to accordion items
  • plug + action to the display key project's store action

UI preview:

item-action.mp4

@rouk1 rouk1 linked an issue Oct 18, 2024 that may be closed by this pull request
Clarify how items can be added to a view #533
Open
@tuscland
Copy link
Member

tuscland commented Oct 18, 2024 •
edited
Loading

I checked out this branch, have an empty view selected, but when I click the + button it does not add the item to the view. Dragging works though.

click-item.mov

tuscland
tuscland requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@tuscland tuscland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment, for me the + button did not work properly.

@tuscland tuscland linked an issue Oct 18, 2024 that may be closed by this pull request
On hover interaction suggests click, no hover #510
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuscland tuscland tuscland requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify how items can be added to a view On hover interaction suggests click, no hover
2 participants
@rouk1 @tuscland