Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): Display indexes in datatables widget #493

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

rouk1
Copy link
Contributor

@rouk1 rouk1 commented Oct 15, 2024

Co-authored with @augustebaum

Screenshot 2024-10-15 at 12 06 46

@rouk1 rouk1 linked an issue Oct 15, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Oct 15, 2024

Coverage Report for ./skore-ui

Status Category Percentage Covered / Total
🔵 Lines 79.95% 1464 / 1831
🔵 Statements 79.95% 1464 / 1831
🔵 Functions 44.89% 44 / 98
🔵 Branches 82.06% 119 / 145
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
skore-ui/src/components/DataFrameWidget.vue 87.5% 81.81% 33.33% 87.5% 50, 60-64, 66-69, 72, 115
skore-ui/src/components/ProjectViewCanvas.vue 100% 100% 100% 100%
skore-ui/src/views/ComponentsView.vue 83.93% 100% 0% 83.93% 32-34, 36-38, 44-53, 55-59, 61-65, 67-69, 111-118, 120-140
Generated in workflow #247 for commit 2e1d16f by the Vitest Coverage Report Action

@thomass-dev thomass-dev merged commit 5929ba8 into main Oct 15, 2024
7 checks passed
@thomass-dev thomass-dev deleted the 376-dataframe-display-displaying-the-row-index branch October 15, 2024 12:43
@thomass-dev
Copy link
Collaborator

thomass-dev commented Oct 15, 2024

In a next iteration, i propose to nicely show the name of the indexes. For instance,

image

#495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataframe display: displaying the row index
3 participants