Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

41 implement a tree view to displays the root mandr and its children #43

Conversation

rouk1
Copy link
Contributor

@rouk1 rouk1 commented Jul 15, 2024

The tree view is now instantiated in the dashboard, it's connected to the server api.
Run make build-frontend then make serve-api and then browse to http://localhost:8000 to see it.

@rouk1 rouk1 linked an issue Jul 15, 2024 that may be closed by this pull request
@rouk1 rouk1 marked this pull request as ready for review July 16, 2024 12:39
@rouk1 rouk1 requested a review from augustebaum July 16, 2024 12:39
Copy link
Member

@tuscland tuscland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take my comments as suggestions, I don't want to block progress at this stage.

frontend/src/components/FileTree.vue Show resolved Hide resolved
frontend/src/components/FileTreeItem.vue Show resolved Hide resolved
frontend/src/components/FileTreeItem.vue Show resolved Hide resolved
Copy link
Contributor

@augustebaum augustebaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few typos to correct and comments to add for clarity

frontend/src/views/DashboardView.vue Show resolved Hide resolved
frontend/tests/components/FileTree.spec.ts Outdated Show resolved Hide resolved
frontend/tests/components/FileTree.spec.ts Outdated Show resolved Hide resolved
frontend/tests/services/api.spec.ts Outdated Show resolved Hide resolved
frontend/tests/test.utils.ts Outdated Show resolved Hide resolved
@rouk1 rouk1 merged commit f7701e3 into main Jul 17, 2024
1 check passed
@rouk1 rouk1 deleted the 41-implement-a-tree-view-to-displays-the-root-mandr-and-its-children branch July 17, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a tree view to displays the root mandr and it's children
3 participants