feat(api): Change views API in the backend #409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change project serialization step to include `views` dictionary rather than a single `layout`.
Remove duplicate test
|
There are a lot of changes, so I really made an effort to make each commit self-contained. Please review commit-by-commit, and don't hesitate to say if a commit should be delayed/put in a separate PR. |
thomass-dev
reviewed
Sep 30, 2024
thomass-dev
reviewed
Sep 30, 2024
There was a problem hiding this comment.
Waiting for your feedbacks 🙏🏻 .
This PR is an API breaking-change, and will break the frontend in state.
Do you think @rouk1 you can work inside this PR as a full-feature PR? If not, could you branch from it and merge on it?
What do you think?
augustebaum
force-pushed
the
views-api
branch
from
e67b289
to
d5be28f
Compare
augustebaum
force-pushed
the
views-api
branch
from
d5be28f
to
943c50b
Compare
augustebaum
changed the title
|
This PR should be trashed. We chose with @augustebaum to work in a full feature PR that will come from the |
|
Closed in profit of #414 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keyargumentLayoutItemSizeAddresses #336