Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to cover the InfoMander class #34

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Conversation

thomass-dev
Copy link
Collaborator

No description provided.

@thomass-dev thomass-dev linked an issue Jul 9, 2024 that may be closed by this pull request
@thomass-dev thomass-dev force-pushed the 16-adding-tests branch 4 times, most recently from 696ac39 to 52cb2e8 Compare July 11, 2024 10:08
@thomass-dev thomass-dev marked this pull request as ready for review July 11, 2024 10:17
tests/unit/test_infomander.py Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
src/mandr/infomander.py Show resolved Hide resolved
@thomass-dev
Copy link
Collaborator Author

thomass-dev commented Jul 11, 2024

I noticed some issues that might be worth discussing:

  • it seems that the prefixed template directory wasn't used (fixed)
  • artifacts were stored on both cache and disk (fixed)
  • i change the updated_at field from time to datetime
  • logs are stored in the cache, not on disk as mentioned
  • in the add_info method, in append mode, new values are putted in front of the list
  • the method dsl_path_exists is not used anywhere and is based on assert

@tuscland
Copy link
Member

LGTM

@thomass-dev
Copy link
Collaborator Author

thomass-dev commented Jul 12, 2024

As discussed with @rouk1, to resolve conflicts between #34 and #36 , we will change the way the dashboard is launched and discover mandr.

At this state, we only want to launch a dashboard on an instance of mandr and all its children.
So, we'll create a launch_dashboard method inside the mandr class, so that we can easily retrieve infos and children without worrying about passing the store path from the URL to the backend dashboard.

@thomass-dev thomass-dev force-pushed the 16-adding-tests branch 2 times, most recently from 2651bb9 to 286ec8b Compare July 16, 2024 10:02
@thomass-dev thomass-dev merged commit 4183f11 into main Jul 16, 2024
1 check passed
@thomass-dev thomass-dev deleted the 16-adding-tests branch July 16, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding tests
3 participants