Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): Change structure to enable dropdowns in sidebar #1325

Merged
merged 13 commits into from
Feb 14, 2025
Merged

Conversation

auguste-probabl
Copy link
Contributor

@auguste-probabl auguste-probabl commented Feb 14, 2025

Our sphinx theme automatically adds dropdowns in the sidebar when the docs are nested in directories and subdirectories. This PR changes the structure of the docs to enable dropdowns.

One trade-off is that toctree and autosummary cannot both be used, so in the API index page, we no longer have a table-formatted list of all the public API functions and classes.

Before:

After:

Supersedes #1302

Closes #1095

Co-authored-by: Guillaume Lemaitre [email protected]

@auguste-probabl auguste-probabl marked this pull request as draft February 14, 2025 15:47
@auguste-probabl auguste-probabl marked this pull request as ready for review February 14, 2025 16:01
Copy link
Contributor

Documentation preview @ be82ec6

Copy link
Contributor

@MarieSacksick MarieSacksick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it's much much nicer!

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Indeed, it is much nicer. We can always improve the landing API page if we find some ways. But it is a net improvement.

@glemaitre glemaitre merged commit fc75b61 into main Feb 14, 2025
9 checks passed
@glemaitre glemaitre deleted the dropdowns branch February 14, 2025 20:27
@glemaitre
Copy link
Member

I'll address my comment in a follow-up PR when working on #1328.

Having those changes will be pretty handy ;)

@sylvaincom
Copy link
Contributor

Many thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Enable drop-downs in the API
4 participants