Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(UI): CWE-346 #1311

Merged
merged 1 commit into from
Feb 12, 2025
Merged

chore(UI): CWE-346 #1311

merged 1 commit into from
Feb 12, 2025

Conversation

rouk1
Copy link
Contributor

@rouk1 rouk1 commented Feb 12, 2025 •
edited by thomass-dev
Loading

Fix security issue by updating skore-ui dependencies https://github.com/probabl-ai/skore/security/dependabot/12.

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report for frontend

Status Category Percentage Covered / Total
🔵 Lines 81.82% 2193 / 2680
🔵 Statements 81.82% 2193 / 2680
🔵 Functions 50.56% 45 / 89
🔵 Branches 83.18% 193 / 232
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
skore-ui/src/components/SimpleButton.vue 100% 100% 100% 100%
skore-ui/src/components/ToastNotification.vue 87.09% 68.75% 100% 87.09% 21, 32-33, 38-42
Generated in workflow #226 for commit 49ce2d4 by the Vitest Coverage Report Action

thomass-dev
thomass-dev requested changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@thomass-dev thomass-dev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a description? Thanks 😄
I understand that this PR intends to upgrade some dependencies of the UI.

I have updated myself.

skore-ui/src/components/SimpleButton.vue Show resolved Hide resolved
skore-ui/src/components/ToastNotification.vue Show resolved Hide resolved
@thomass-dev thomass-dev merged commit b5f84ad into probabl-ai:main Feb 12, 2025
7 checks passed
@rouk1 rouk1 deleted the cve-fix branch February 12, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomass-dev thomass-dev thomass-dev approved these changes

Assignees

@rouk1 rouk1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rouk1 @thomass-dev