-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): Transpose the report table #1306
Conversation
It is ready for review @thomass-dev and @auguste-probabl |
Whoops. I need to change all the docstring but it will be quick ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! I tried this in the console and got this:
>>> report.metrics.report_metrics()
LogisticRegression
Split #0 Split #1
Metric Label / Average
Precision (↗︎) 0 1.000000 0.857143
1 1.000000 0.954545
Recall (↗︎) 0 1.000000 0.960000
1 1.000000 0.840000
ROC AUC (↗︎) 1.000000 0.992000
Brier score (↘︎) 0.023925 0.049771
It's not aligned, and I don't understand why (I guess it's a Pandas thing).
Yep. The resolution of #1260 will probably solve the problem :) We are getting there :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick win. So far better, thanks!
Coverage Report for backend
|
Next PR :) |
closes #1270
Transpose the
report_metrics
output to ease the addition of the favorability of the metrics as a column.The PR mainly change the
.columns
to.index
in the tests and avoid the unnecessary transpose in example.