docs: Change colors of links

[MarieSacksick]

Closes #1008

[github-actions]

Documentation preview @ d1edd3f

[glemaitre]

Thinking a bit more about the problem, I think that we should instead overload the color define in the theme: https://github.com/pydata/pydata-sphinx-theme/blob/3d03aee9088e03ccacff320a836889cb8396d801/src/pydata_sphinx_theme/assets/styles/variables/_color.scss#L285-L286

As far I see, we should have to redefine:

--pst-color-link
--pst-color-link-hover
--pst-color-inline-code-links

So it means that any CSS rule using those colors will then be consistent.

[sylvaincom]

I think there are too many different colors, especially Project is underlined in orange

[glemaitre]

That's why you better redefined the color rather than modify the HTML objects.

[MarieSacksick]

Yes, it's a draft, it's not working the way I want for now. I think I'll spend another hour trying, and then stop, because I don't think it's worth it.

@glemaitre, when you say "That's why you better redefined the color rather than modify the HTML objects.", do you mean that these colors are instantiated somewhere and I can modify them? That would make things much easier!

Edit: ok, I found it. And after I read that you had the solution Guillaume 😅

[auguste-probabl]

Thanks! Indeed CSS is the right way to do this IMO.

[glemaitre]

Indeed, it is what I have in mind. You need to check the rendering but it was the idea.

[MarieSacksick]

yes, the colors for light mode are not exactly those of the logo because the contrast was not nearly high enough, but it's the same idea, orange and blue, only darker.