Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh: transpose the output of report_metrics #1270

Closed
glemaitre opened this issue Jan 31, 2025 · 5 comments · Fixed by #1306
Closed

enh: transpose the output of report_metrics #1270

glemaitre opened this issue Jan 31, 2025 · 5 comments · Fixed by #1306
Milestone
skore 0.7

Comments

@glemaitre
Copy link
Member

As discussed in #1260, it would make sense to transpose rows and columns in the .report_metrics
@glemaitre glemaitre mentioned this issue Feb 11, 2025
Merged
@glemaitre
Copy link
Member Author

I would suggest milestone 0.7

@sylvaincom sylvaincom added this to the skore 0.7 milestone Feb 11, 2025
@sylvaincom
Copy link
Contributor

@MarieS-WiMLDS I added milestone 0.7 if that's ok with you

@MarieSacksick
Copy link
Contributor

If it's ready when compare is, it's a bonus, but I will not delay the release for this.

@glemaitre
Copy link
Member Author

It is already ready :P

thomass-dev pushed a commit that referenced this issue Feb 12, 2025
@glemaitre
fix(api): Transpose the report table (#1306)
c75e193 
closes #1270 

Transpose the `report_metrics` output to ease the addition of the
favorability of the metrics as a column.

The PR mainly change the `.columns` to `.index` in the tests and avoid
the unnecessary transpose in example.
@MarieSacksick
Copy link
Contributor

great :) !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
skore 0.7
Development

Successfully merging a pull request may close this issue.

fix(api): Transpose the report table glemaitre/skore
3 participants
@glemaitre @sylvaincom @MarieSacksick